Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/public/platform/Platform.h

Issue 2588403002: TestingPlatformSupport: register Platform instance correctly (Closed)
Patch Set: new plan Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp ('K') | « third_party/WebKit/Source/platform/weborigin/OriginAccessEntryTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/Platform.h
diff --git a/third_party/WebKit/public/platform/Platform.h b/third_party/WebKit/public/platform/Platform.h
index 4264a4cd22d5e6a7a3757f12025b6c572370b9dc..99bf13d9fb3a81a8ab9daec116c85c8a6a7a49d5 100644
--- a/third_party/WebKit/public/platform/Platform.h
+++ b/third_party/WebKit/public/platform/Platform.h
@@ -138,7 +138,9 @@ class BLINK_PLATFORM_EXPORT Platform {
static void shutdown();
static Platform* current();
- // Used to switch the current platform only for testing.
+ // Used to switch the current platform only for testing. Since this method
+ // calls virtual methods internally, you should not call with self instance
Takashi Toyoshima 2016/12/22 06:29:06 probably worth noting
+ // inside a Platform subclass's constructor.
static void setCurrentPlatformForTesting(Platform*);
// May return null.
« third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp ('K') | « third_party/WebKit/Source/platform/weborigin/OriginAccessEntryTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698