Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp

Issue 2588403002: TestingPlatformSupport: register Platform instance correctly (Closed)
Patch Set: review #32 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp
diff --git a/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp b/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp
index 551005152cb1f4df5feb938782ca4236a1c40ae8..bff5c00b75f2843cb7f30e6d52ae7f5216fe4728 100644
--- a/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp
+++ b/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp
@@ -128,10 +128,11 @@ class AnimationWorkletThreadTest : public ::testing::Test {
RefPtr<SecurityOrigin> m_securityOrigin;
std::unique_ptr<WorkerReportingProxy> m_reportingProxy;
- AnimationWorkletTestPlatform m_testPlatform;
};
TEST_F(AnimationWorkletThreadTest, Basic) {
+ ScopedTestingPlatformSupport<AnimationWorkletTestPlatform> platform;
+
std::unique_ptr<AnimationWorkletThread> worklet =
createAnimationWorkletThread();
checkWorkletCanExecuteScript(worklet.get());
@@ -141,6 +142,8 @@ TEST_F(AnimationWorkletThreadTest, Basic) {
// Tests that the same WebThread is used for new worklets if the WebThread is
// still alive.
TEST_F(AnimationWorkletThreadTest, CreateSecondAndTerminateFirst) {
+ ScopedTestingPlatformSupport<AnimationWorkletTestPlatform> platform;
+
// Create the first worklet and wait until it is initialized.
std::unique_ptr<AnimationWorkletThread> firstWorklet =
createAnimationWorkletThread();
@@ -176,6 +179,8 @@ TEST_F(AnimationWorkletThreadTest, CreateSecondAndTerminateFirst) {
// Tests that a new WebThread is created if all existing worklets are
// terminated before a new worklet is created.
TEST_F(AnimationWorkletThreadTest, TerminateFirstAndCreateSecond) {
+ ScopedTestingPlatformSupport<AnimationWorkletTestPlatform> platform;
+
// Create the first worklet, wait until it is initialized, and terminate it.
std::unique_ptr<AnimationWorkletThread> worklet =
createAnimationWorkletThread();
@@ -200,6 +205,8 @@ TEST_F(AnimationWorkletThreadTest, TerminateFirstAndCreateSecond) {
// Tests that v8::Isolate and WebThread are correctly set-up if a worklet is
// created while another is terminating.
TEST_F(AnimationWorkletThreadTest, CreatingSecondDuringTerminationOfFirst) {
+ ScopedTestingPlatformSupport<AnimationWorkletTestPlatform> platform;
+
std::unique_ptr<AnimationWorkletThread> firstWorklet =
createAnimationWorkletThread();
checkWorkletCanExecuteScript(firstWorklet.get());

Powered by Google App Engine
This is Rietveld 408576698