TestingPlatformSupport: register Platform instance correctly

third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/dom/ScriptRunner.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/dom/ScriptLoader.h"
 #include "platform/heap/Handle.h"
 #include "platform/testing/TestingPlatformSupport.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebViewScheduler.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "wtf/PtrUtil.h"
 
 using ::testing::Invoke;
 using ::testing::ElementsAre;
 using ::testing::Return;
 using ::testing::WhenSorted;
 using ::testing::ElementsAreArray;
 
 namespace blink {
 
 class MockScriptLoader final : public ScriptLoader {
@@ skipping 11 matching lines @@
       : ScriptLoader(element, false, false, false) {}
 };
 
 class ScriptRunnerTest : public testing::Test {
  public:
   ScriptRunnerTest()
       : m_document(Document::create()),
         m_element(m_document->createElement("foo")) {}
 
   void SetUp() override {
+    m_platform.reset(
+        WTF::makeUnique<TestingPlatformSupportWithMockScheduler>());
     // We have to create ScriptRunner after initializing platform, because we
     // need Platform::current()->currentThread()->scheduler()->
     // loadingTaskRunner() to be initialized before creating ScriptRunner to
     // save it in constructor.
     m_scriptRunner = ScriptRunner::create(m_document.get());
   }
 
   void TearDown() override { m_scriptRunner.release(); }
 
   Persistent<Document> m_document;
   Persistent<Element> m_element;
-  TestingPlatformSupportWithMockScheduler m_platform;
+  ScopedTestingPlatformSupport<TestingPlatformSupportWithMockScheduler>

[haraken, 2017/01/11 13:03:38]

Hmm. It looks a bit nasty to allocate a "Scoped" object on a on-heap object.
It's not scoped and actually you're manually resetting the object at every
SetUp().

Would it be nasty to allocate ScopedTestingPlatformSupport in each test, just
like OriginAccessEntryTest.cpp is doing?

[Takashi Toyoshima, 2017/01/12 08:56:13]

I do not feel it's nasty to use ScopedFoo in members because it has been a
chrome style outside blink though majority was already replaced with
std::unique_ptr.

But, as you suggested, restricting this class as STACK_ALLOCATED would help
reducing complexity, and it looks reasonable to use this class via AutoLock like
interface.

I will change the template class a little so that we can place it in each test
more easily.

+      m_platform;
   Persistent<ScriptRunner> m_scriptRunner;
   WTF::Vector<int> m_order;
 };
 
 TEST_F(ScriptRunnerTest, QueueSingleScript_Async) {
   MockScriptLoader* scriptLoader = MockScriptLoader::create(m_element.get());
   m_scriptRunner->queueScriptForExecution(scriptLoader, ScriptRunner::Async);
   m_scriptRunner->notifyScriptReady(scriptLoader, ScriptRunner::Async);
 
   EXPECT_CALL(*scriptLoader, execute());
-  m_platform.runUntilIdle();
+  m_platform->runUntilIdle();
 }
 
 TEST_F(ScriptRunnerTest, QueueSingleScript_InOrder) {
   MockScriptLoader* scriptLoader = MockScriptLoader::create(m_element.get());
   m_scriptRunner->queueScriptForExecution(scriptLoader, ScriptRunner::InOrder);
 
   EXPECT_CALL(*scriptLoader, isReady()).WillOnce(Return(true));
   EXPECT_CALL(*scriptLoader, execute());
 
   m_scriptRunner->notifyScriptReady(scriptLoader, ScriptRunner::InOrder);
 
-  m_platform.runUntilIdle();
+  m_platform->runUntilIdle();
 }
 
 TEST_F(ScriptRunnerTest, QueueMultipleScripts_InOrder) {
   MockScriptLoader* scriptLoader1 = MockScriptLoader::create(m_element.get());
   MockScriptLoader* scriptLoader2 = MockScriptLoader::create(m_element.get());
   MockScriptLoader* scriptLoader3 = MockScriptLoader::create(m_element.get());
 
   HeapVector<Member<MockScriptLoader>> scriptLoaders;
   scriptLoaders.push_back(scriptLoader1);
   scriptLoaders.push_back(scriptLoader2);
@@ skipping 14 matching lines @@
   bool isReady[] = {false, false, false};
 
   for (size_t i = 0; i < scriptLoaders.size(); ++i) {
     EXPECT_CALL(*scriptLoaders[i], isReady())
         .WillRepeatedly(Invoke([&isReady, i] { return isReady[i]; }));
   }
 
   for (int i = 2; i >= 0; i--) {
     isReady[i] = true;
     m_scriptRunner->notifyScriptReady(scriptLoaders[i], ScriptRunner::InOrder);
-    m_platform.runUntilIdle();
+    m_platform->runUntilIdle();
   }
 
   // But ensure the scripts were run in the expected order.
   EXPECT_THAT(m_order, ElementsAre(1, 2, 3));
 }
 
 TEST_F(ScriptRunnerTest, QueueMixedScripts) {
   MockScriptLoader* scriptLoader1 = MockScriptLoader::create(m_element.get());
   MockScriptLoader* scriptLoader2 = MockScriptLoader::create(m_element.get());
   MockScriptLoader* scriptLoader3 = MockScriptLoader::create(m_element.get());
@@ skipping 29 matching lines @@
   EXPECT_CALL(*scriptLoader3, execute()).WillOnce(Invoke([this] {
     m_order.push_back(3);
   }));
   EXPECT_CALL(*scriptLoader4, execute()).WillOnce(Invoke([this] {
     m_order.push_back(4);
   }));
   EXPECT_CALL(*scriptLoader5, execute()).WillOnce(Invoke([this] {
     m_order.push_back(5);
   }));
 
-  m_platform.runUntilIdle();
+  m_platform->runUntilIdle();
 
   // Async tasks are expected to run first.
   EXPECT_THAT(m_order, ElementsAre(4, 5, 1, 2, 3));
 }
 
 TEST_F(ScriptRunnerTest, QueueReentrantScript_Async) {
   MockScriptLoader* scriptLoader1 = MockScriptLoader::create(m_element.get());
   MockScriptLoader* scriptLoader2 = MockScriptLoader::create(m_element.get());
   MockScriptLoader* scriptLoader3 = MockScriptLoader::create(m_element.get());
 
@@ skipping 13 matching lines @@
     m_order.push_back(2);
     m_scriptRunner->notifyScriptReady(scriptLoader, ScriptRunner::Async);
   }));
 
   EXPECT_CALL(*scriptLoader3, execute()).WillOnce(Invoke([this] {
     m_order.push_back(3);
   }));
 
   // Make sure that re-entrant calls to notifyScriptReady don't cause
   // ScriptRunner::execute to do more work than expected.
-  m_platform.runSingleTask();
+  m_platform->runSingleTask();
   EXPECT_THAT(m_order, ElementsAre(1));
 
-  m_platform.runSingleTask();
+  m_platform->runSingleTask();
   EXPECT_THAT(m_order, ElementsAre(1, 2));
 
-  m_platform.runSingleTask();
+  m_platform->runSingleTask();
   EXPECT_THAT(m_order, ElementsAre(1, 2, 3));
 }
 
 TEST_F(ScriptRunnerTest, QueueReentrantScript_InOrder) {
   MockScriptLoader* scriptLoader1 = MockScriptLoader::create(m_element.get());
   MockScriptLoader* scriptLoader2 = MockScriptLoader::create(m_element.get());
   MockScriptLoader* scriptLoader3 = MockScriptLoader::create(m_element.get());
 
   EXPECT_CALL(*scriptLoader1, isReady()).WillRepeatedly(Return(true));
   EXPECT_CALL(*scriptLoader2, isReady()).WillRepeatedly(Return(true));
@@ skipping 19 matching lines @@
                                                 ScriptRunner::InOrder);
         m_scriptRunner->notifyScriptReady(scriptLoader3, ScriptRunner::InOrder);
       }));
 
   EXPECT_CALL(*scriptLoader3, execute()).WillOnce(Invoke([this] {
     m_order.push_back(3);
   }));
 
   // Make sure that re-entrant calls to queueScriptForExecution don't cause
   // ScriptRunner::execute to do more work than expected.
-  m_platform.runSingleTask();
+  m_platform->runSingleTask();
   EXPECT_THAT(m_order, ElementsAre(1));
 
-  m_platform.runSingleTask();
+  m_platform->runSingleTask();
   EXPECT_THAT(m_order, ElementsAre(1, 2));
 
-  m_platform.runSingleTask();
+  m_platform->runSingleTask();
   EXPECT_THAT(m_order, ElementsAre(1, 2, 3));
 }
 
 TEST_F(ScriptRunnerTest, QueueReentrantScript_ManyAsyncScripts) {
   MockScriptLoader* scriptLoaders[20];
   for (int i = 0; i < 20; i++)
     scriptLoaders[i] = nullptr;
 
   for (int i = 0; i < 20; i++) {
     scriptLoaders[i] = MockScriptLoader::create(m_element.get());
@@ skipping 13 matching lines @@
   m_scriptRunner->notifyScriptReady(scriptLoaders[1], ScriptRunner::Async);
 
   EXPECT_CALL(*scriptLoaders[0], execute())
       .WillOnce(Invoke([&scriptLoaders, this] {
         for (int i = 2; i < 20; i++)
           m_scriptRunner->notifyScriptReady(scriptLoaders[i],
                                             ScriptRunner::Async);
         m_order.push_back(0);
       }));
 
-  m_platform.runUntilIdle();
+  m_platform->runUntilIdle();
 
   int expected[] = {0,  1,  2,  3,  4,  5,  6,  7,  8,  9,
                     10, 11, 12, 13, 14, 15, 16, 17, 18, 19};
 
   EXPECT_THAT(m_order, testing::ElementsAreArray(expected));
 }
 
 TEST_F(ScriptRunnerTest, ResumeAndSuspend_InOrder) {
   MockScriptLoader* scriptLoader1 = MockScriptLoader::create(m_element.get());
   MockScriptLoader* scriptLoader2 = MockScriptLoader::create(m_element.get());
@@ skipping 20 matching lines @@
   EXPECT_CALL(*scriptLoader2, isReady()).WillRepeatedly(Return(false));
   m_scriptRunner->notifyScriptReady(scriptLoader1, ScriptRunner::InOrder);
 
   EXPECT_CALL(*scriptLoader2, isReady()).WillRepeatedly(Return(true));
   EXPECT_CALL(*scriptLoader3, isReady()).WillRepeatedly(Return(false));
   m_scriptRunner->notifyScriptReady(scriptLoader2, ScriptRunner::InOrder);
 
   EXPECT_CALL(*scriptLoader3, isReady()).WillRepeatedly(Return(true));
   m_scriptRunner->notifyScriptReady(scriptLoader3, ScriptRunner::InOrder);
 
-  m_platform.runSingleTask();
+  m_platform->runSingleTask();
   m_scriptRunner->suspend();
   m_scriptRunner->resume();
-  m_platform.runUntilIdle();
+  m_platform->runUntilIdle();
 
   // Make sure elements are correct and in right order.
   EXPECT_THAT(m_order, ElementsAre(1, 2, 3));
 }
 
 TEST_F(ScriptRunnerTest, ResumeAndSuspend_Async) {
   MockScriptLoader* scriptLoader1 = MockScriptLoader::create(m_element.get());
   MockScriptLoader* scriptLoader2 = MockScriptLoader::create(m_element.get());
   MockScriptLoader* scriptLoader3 = MockScriptLoader::create(m_element.get());
 
   m_scriptRunner->queueScriptForExecution(scriptLoader1, ScriptRunner::Async);
   m_scriptRunner->queueScriptForExecution(scriptLoader2, ScriptRunner::Async);
   m_scriptRunner->queueScriptForExecution(scriptLoader3, ScriptRunner::Async);
 
   m_scriptRunner->notifyScriptReady(scriptLoader1, ScriptRunner::Async);
   m_scriptRunner->notifyScriptReady(scriptLoader2, ScriptRunner::Async);
   m_scriptRunner->notifyScriptReady(scriptLoader3, ScriptRunner::Async);
 
   EXPECT_CALL(*scriptLoader1, execute()).WillOnce(Invoke([this] {
     m_order.push_back(1);
   }));
   EXPECT_CALL(*scriptLoader2, execute()).WillOnce(Invoke([this] {
     m_order.push_back(2);
   }));
   EXPECT_CALL(*scriptLoader3, execute()).WillOnce(Invoke([this] {
     m_order.push_back(3);
   }));
 
-  m_platform.runSingleTask();
+  m_platform->runSingleTask();
   m_scriptRunner->suspend();
   m_scriptRunner->resume();
-  m_platform.runUntilIdle();
+  m_platform->runUntilIdle();
 
   // Make sure elements are correct.
   EXPECT_THAT(m_order, WhenSorted(ElementsAre(1, 2, 3)));
 }
 
 TEST_F(ScriptRunnerTest, LateNotifications) {
   MockScriptLoader* scriptLoader1 = MockScriptLoader::create(m_element.get());
   MockScriptLoader* scriptLoader2 = MockScriptLoader::create(m_element.get());
 
   EXPECT_CALL(*scriptLoader1, isReady()).WillRepeatedly(Return(true));
   EXPECT_CALL(*scriptLoader2, isReady()).WillRepeatedly(Return(true));
 
   m_scriptRunner->queueScriptForExecution(scriptLoader1, ScriptRunner::InOrder);
   m_scriptRunner->queueScriptForExecution(scriptLoader2, ScriptRunner::InOrder);
 
   EXPECT_CALL(*scriptLoader1, execute()).WillOnce(Invoke([this] {
     m_order.push_back(1);
   }));
   EXPECT_CALL(*scriptLoader2, execute()).WillOnce(Invoke([this] {
     m_order.push_back(2);
   }));
 
   m_scriptRunner->notifyScriptReady(scriptLoader1, ScriptRunner::InOrder);
-  m_platform.runUntilIdle();
+  m_platform->runUntilIdle();
 
   // At this moment all tasks can be already executed. Make sure that we do not
   // crash here.
   m_scriptRunner->notifyScriptReady(scriptLoader2, ScriptRunner::InOrder);
-  m_platform.runUntilIdle();
+  m_platform->runUntilIdle();
 
   EXPECT_THAT(m_order, ElementsAre(1, 2));
 }
 
 TEST_F(ScriptRunnerTest, TasksWithDeadScriptRunner) {
   Persistent<MockScriptLoader> scriptLoader1 =
       MockScriptLoader::create(m_element.get());
   Persistent<MockScriptLoader> scriptLoader2 =
       MockScriptLoader::create(m_element.get());
 
   EXPECT_CALL(*scriptLoader1, isReady()).WillRepeatedly(Return(true));
   EXPECT_CALL(*scriptLoader2, isReady()).WillRepeatedly(Return(true));
 
   m_scriptRunner->queueScriptForExecution(scriptLoader1, ScriptRunner::Async);
   m_scriptRunner->queueScriptForExecution(scriptLoader2, ScriptRunner::Async);
 
   m_scriptRunner->notifyScriptReady(scriptLoader1, ScriptRunner::Async);
   m_scriptRunner->notifyScriptReady(scriptLoader2, ScriptRunner::Async);
 
   m_scriptRunner.release();
 
   ThreadState::current()->collectAllGarbage();
 
   // m_scriptRunner is gone. We need to make sure that ScriptRunner::Task do not
   // access dead object.
   EXPECT_CALL(*scriptLoader1, execute()).Times(0);
   EXPECT_CALL(*scriptLoader2, execute()).Times(0);
 
-  m_platform.runUntilIdle();
+  m_platform->runUntilIdle();
 }
 
 }  // namespace blink