TestingPlatformSupport: register Platform instance correctly

third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 123 matching lines @@
 TestingPlatformMockScheduler::TestingPlatformMockScheduler() {}
 TestingPlatformMockScheduler::~TestingPlatformMockScheduler() {}
 
 TestingPlatformSupport::TestingPlatformSupport()
     : TestingPlatformSupport(TestingPlatformSupport::Config()) {}
 
 TestingPlatformSupport::TestingPlatformSupport(const Config& config)
     : m_config(config),
       m_oldPlatform(Platform::current()),
       m_interfaceProvider(new TestingInterfaceProvider) {
-  ASSERT(m_oldPlatform);
-  Platform::setCurrentPlatformForTesting(this);
+  DCHECK(m_oldPlatform);
 }
 
 TestingPlatformSupport::~TestingPlatformSupport() {
-  Platform::setCurrentPlatformForTesting(m_oldPlatform);
+  // Checks if Platform::setCurrentPlatformForTesting() was correctly called
+  // after the construction.
+  DCHECK_NE(m_oldPlatform, Platform::current());

[Takashi Toyoshima, 2016/12/22 06:29:06]

I confirm that this check actually works to catch wrong usages, using
TestingPlatformSupport or its sub-classes without ScopedTestingPlatformSupport.

 }
 
 WebString TestingPlatformSupport::defaultLocale() {
   return WebString::fromUTF8("en-US");
 }
 
 WebCompositorSupport* TestingPlatformSupport::compositorSupport() {
   if (m_config.compositorSupport)
     return m_config.compositorSupport;
 
@@ skipping 165 matching lines @@
 
   m_platform = WTF::wrapUnique(new DummyPlatform);
   Platform::setCurrentPlatformForTesting(m_platform.get());
 
   WTF::Partitions::initialize(nullptr);
   WTF::setTimeFunctionsForTesting(dummyCurrentTime);
   WTF::initialize(nullptr);
 
   m_compositorSupport = WTF::wrapUnique(new cc_blink::WebCompositorSupportImpl);
   m_testingPlatformConfig.compositorSupport = m_compositorSupport.get();
-  m_testingPlatformSupport =
-      WTF::makeUnique<TestingPlatformSupport>(m_testingPlatformConfig);
+  m_testingPlatformSupport.reset(
+      new TestingPlatformSupport(m_testingPlatformConfig));
 
   ProcessHeap::init();
   ThreadState::attachMainThread();
   ThreadState::current()->registerTraceDOMWrappers(nullptr, nullptr, nullptr,
                                                    nullptr);
   HTTPNames::init();
 }
 
 ScopedUnittestsEnvironmentSetup::~ScopedUnittestsEnvironmentSetup() {}
 
 }  // namespace blink