third_party/WebKit/Source/platform/testing/DEPS - Issue 2588403002: TestingPlatformSupport: register Platform instance correctly

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/testing/DEPS

Issue 2588403002: TestingPlatformSupport: register Platform instance correctly (Closed)

Patch Set: new plan Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # To whitelist base/ stuff Blink is allowed to include, we list up all	2 # To whitelist base/ stuff Blink is allowed to include, we list up all

3 # directories and files instead of writing 'base/'.	3 # directories and files instead of writing 'base/'.

4 "+base/at_exit.h",	4 "+base/at_exit.h",

5 "+base/command_line.h",	5 "+base/command_line.h",

6 "+base/i18n/icu_util.h",	6 "+base/i18n/icu_util.h",

	7 "+base/logging.h",
	Takashi Toyoshima 2016/12/22 06:29:06 for DCHECK for DCHECK jbroman 2016/12/22 15:27:54 DCHECK is available via wtf/Assertions.h; that's h Show quoted text On 2016/12/22 at 06:29:06, toyoshim wrote: > for DCHECK DCHECK is available via wtf/Assertions.h; that's how other places get it currently. Takashi Toyoshima 2017/01/11 08:35:19 Done. Show quoted text On 2016/12/22 15:27:54, jbroman wrote: > On 2016/12/22 at 06:29:06, toyoshim wrote: > > for DCHECK > > DCHECK is available via wtf/Assertions.h; that's how other places get it > currently. Done.
7 "+base/path_service.h",	8 "+base/path_service.h",

8 "+base/run_loop.h",	9 "+base/run_loop.h",

9 "+base/message_loop",	10 "+base/message_loop",

10 "+base/metrics/statistics_recorder.h",	11 "+base/metrics/statistics_recorder.h",

11 "+base/test/test_io_thread.h",	12 "+base/test/test_io_thread.h",

12 "+cc",	13 "+cc",

13 "+mojo/edk/embedder",	14 "+mojo/edk/embedder",

14 "+mojo/edk/test",	15 "+mojo/edk/test",

15 ]	16 ]

OLD	NEW