net/websockets/websocket_channel_test.cc - Issue 258833005: [WebSocket] Fix a crash caused by a pending empty frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/websockets/websocket_channel_test.cc

Issue 258833005: [WebSocket] Fix a crash caused by a pending empty frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/websockets/websocket_channel_test.cc

diff --git a/net/websockets/websocket_channel_test.cc b/net/websockets/websocket_channel_test.cc

index 82078cbbf9e1a360059793d5f163366f82340646..464c30e161957aa83ed35e446209d65fc7f89176 100644

--- a/net/websockets/websocket_channel_test.cc

+++ b/net/websockets/websocket_channel_test.cc

@@ -2406,7 +2406,7 @@ TEST_F(WebSocketChannelFlowControlTest, EmptyMessageNoQuota) {

{FINAL_FRAME, WebSocketFrameHeader::kOpCodeText,

NOT_MASKED, "FIRST MESSAGE"},

{FINAL_FRAME, WebSocketFrameHeader::kOpCodeText,

- NOT_MASKED, ""},

+ NOT_MASKED, NULL},

{FINAL_FRAME, WebSocketFrameHeader::kOpCodeText,

NOT_MASKED, "THIRD MESSAGE"}};

stream->PrepareReadFrames(ReadableFakeWebSocketStream::SYNC, OK, frames);

« net/websockets/websocket_channel.cc ('K') | « net/websockets/websocket_channel.cc ('k') | no next file » | no next file with comments »