[WebSocket] Fix a crash caused by a pending empty frame.

[WebSocket] Fix a crash caused by a pending empty frame.

This CL fixes the process that sends pending frames when a WebSocketChannel
receives quota from the renderer process. The IOBuffer data of a frame can
be null, but the implementation didn't take account of that.

BUG=364788
R=ricea@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266513

[Adam Rice, 2014-04-28 04:30:07]

https://codereview.chromium.org/258833005/diff/40001/net/websockets/websocket...
File net/websockets/websocket_channel.cc (right):

https://codereview.chromium.org/258833005/diff/40001/net/websockets/websocket...
net/websockets/websocket_channel.cc:412: const std::vector<char>
data_vector(data, data + bytes_to_send);
It would be nice to have a check like

if (bytes_to_send)
  DCHECK(data);

here.

[yhirano, 2014-04-28 04:38:16]

https://codereview.chromium.org/258833005/diff/40001/net/websockets/websocket...
File net/websockets/websocket_channel.cc (right):

https://codereview.chromium.org/258833005/diff/40001/net/websockets/websocket...
net/websockets/websocket_channel.cc:412: const std::vector<char>
data_vector(data, data + bytes_to_send);
On 2014/04/28 04:30:08, Adam Rice wrote:
> It would be nice to have a check like
> 
> if (bytes_to_send)
>   DCHECK(data);
> 
> here.

Done.

[Adam Rice, 2014-04-28 05:14:17]

lgtm

[yhirano, 2014-04-28 05:21:51]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2014-04-28 05:23:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yhirano@chromium.org/258833005/60001

[commit-bot: I haz the power, 2014-04-28 12:10:48]

Change committed as 266513