Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: ui/views/widget/native_widget_aura.cc

Issue 258833002: Add dcheck to make sure the maximizable window does not have maximum size (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/native_widget_aura.cc
diff --git a/ui/views/widget/native_widget_aura.cc b/ui/views/widget/native_widget_aura.cc
index df9ace0b9dda84a48100fd8b34e4ef4983346bd0..c28fefd1a40718bd237163b4b8f48630b89dfd23 100644
--- a/ui/views/widget/native_widget_aura.cc
+++ b/ui/views/widget/native_widget_aura.cc
@@ -696,6 +696,10 @@ gfx::Size NativeWidgetAura::GetMinimumSize() const {
}
gfx::Size NativeWidgetAura::GetMaximumSize() const {
+ // If a window havea maximum size, the window should not be
Ben Goodger (Google) 2014/04/25 19:29:32 have a
tfarina 2014/04/25 19:30:16 s/havea/have a Although my English is not all the
oshima 2014/04/25 22:20:56 Done.
+ // maximizable.
+ DCHECK(delegate_->GetMaximumSize().IsEmpty() ||
+ !window_->GetProperty(aura::client::kCanMaximizeKey));
return delegate_->GetMaximumSize();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698