|
|
Created:
6 years, 8 months ago by oshima Modified:
6 years, 8 months ago Reviewers:
Ben Goodger (Google) CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionAdd dcheck to make sure the maximizable window does not have maximum size
BUG=None
R=ben@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266461
Patch Set 1 : #
Total comments: 3
Patch Set 2 : #Patch Set 3 : #Messages
Total messages: 16 (0 generated)
lgtm https://codereview.chromium.org/258833002/diff/60001/ui/views/widget/native_w... File ui/views/widget/native_widget_aura.cc (right): https://codereview.chromium.org/258833002/diff/60001/ui/views/widget/native_w... ui/views/widget/native_widget_aura.cc:699: // If a window havea maximum size, the window should not be have a
https://codereview.chromium.org/258833002/diff/60001/ui/views/widget/native_w... File ui/views/widget/native_widget_aura.cc (right): https://codereview.chromium.org/258833002/diff/60001/ui/views/widget/native_w... ui/views/widget/native_widget_aura.cc:699: // If a window havea maximum size, the window should not be s/havea/have a Although my English is not all the good, and I don't have a proficiency level, I'd write it as "If a window has the ..." Just curius, if the window has the maximum size possible, doesn't that mean it is maximized? Please, just ignore this question, if I'm asking something dumb or non-sense.
https://codereview.chromium.org/258833002/diff/60001/ui/views/widget/native_w... File ui/views/widget/native_widget_aura.cc (right): https://codereview.chromium.org/258833002/diff/60001/ui/views/widget/native_w... ui/views/widget/native_widget_aura.cc:699: // If a window havea maximum size, the window should not be On 2014/04/25 19:29:32, Ben Goodger (Google) wrote: > have a Done.
On 2014/04/25 19:30:16, tfarina wrote: > https://codereview.chromium.org/258833002/diff/60001/ui/views/widget/native_w... > File ui/views/widget/native_widget_aura.cc (right): > > https://codereview.chromium.org/258833002/diff/60001/ui/views/widget/native_w... > ui/views/widget/native_widget_aura.cc:699: // If a window havea maximum size, > the window should not be > s/havea/have a > > Although my English is not all the good, and I don't have a proficiency level, > I'd write it as "If a window has the ..." > > Just curius, if the window has the maximum size possible, doesn't that mean it > is maximized? Please, just ignore this question, if I'm asking something dumb or > non-sense. I'm not sure if I understand correctly, but maximized window has different appearance and has has different behavior (when restored or toggling fullscreen etc), so it's not same as a normal window with its maximum size. hope this helps.
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/258833002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/258833002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/258833002/100001
Message was sent while issue was closed.
Change committed as 266461 |