Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issue 258833002: Add dcheck to make sure the maximizable window does not have maximum size (Closed)

Created:
6 years, 8 months ago by oshima
Modified:
6 years, 8 months ago
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Visibility:
Public.

Description

Add dcheck to make sure the maximizable window does not have maximum size BUG=None R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266461

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/views/widget/native_widget_aura.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
oshima
6 years, 8 months ago (2014-04-25 18:56:00 UTC) #1
Ben Goodger (Google)
lgtm https://codereview.chromium.org/258833002/diff/60001/ui/views/widget/native_widget_aura.cc File ui/views/widget/native_widget_aura.cc (right): https://codereview.chromium.org/258833002/diff/60001/ui/views/widget/native_widget_aura.cc#newcode699 ui/views/widget/native_widget_aura.cc:699: // If a window havea maximum size, the ...
6 years, 8 months ago (2014-04-25 19:29:32 UTC) #2
tfarina
https://codereview.chromium.org/258833002/diff/60001/ui/views/widget/native_widget_aura.cc File ui/views/widget/native_widget_aura.cc (right): https://codereview.chromium.org/258833002/diff/60001/ui/views/widget/native_widget_aura.cc#newcode699 ui/views/widget/native_widget_aura.cc:699: // If a window havea maximum size, the window ...
6 years, 8 months ago (2014-04-25 19:30:16 UTC) #3
oshima
https://codereview.chromium.org/258833002/diff/60001/ui/views/widget/native_widget_aura.cc File ui/views/widget/native_widget_aura.cc (right): https://codereview.chromium.org/258833002/diff/60001/ui/views/widget/native_widget_aura.cc#newcode699 ui/views/widget/native_widget_aura.cc:699: // If a window havea maximum size, the window ...
6 years, 8 months ago (2014-04-25 22:20:56 UTC) #4
oshima
On 2014/04/25 19:30:16, tfarina wrote: > https://codereview.chromium.org/258833002/diff/60001/ui/views/widget/native_widget_aura.cc > File ui/views/widget/native_widget_aura.cc (right): > > https://codereview.chromium.org/258833002/diff/60001/ui/views/widget/native_widget_aura.cc#newcode699 > ...
6 years, 8 months ago (2014-04-26 01:28:21 UTC) #5
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 8 months ago (2014-04-26 01:28:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/258833002/100001
6 years, 8 months ago (2014-04-26 02:04:45 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 02:36:38 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
6 years, 8 months ago (2014-04-26 02:36:39 UTC) #9
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 8 months ago (2014-04-26 03:53:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/258833002/100001
6 years, 8 months ago (2014-04-26 03:54:22 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 05:37:22 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-26 05:37:23 UTC) #13
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 8 months ago (2014-04-26 16:27:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/258833002/100001
6 years, 8 months ago (2014-04-26 16:29:05 UTC) #15
commit-bot: I haz the power
6 years, 8 months ago (2014-04-28 07:08:11 UTC) #16
Message was sent while issue was closed.
Change committed as 266461

Powered by Google App Engine
This is Rietveld 408576698