Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_types.py

Issue 2588303002: bindings: Don't wrap nullable callback functions in Nullable<T> (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_types.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_types.py b/third_party/WebKit/Source/bindings/scripts/v8_types.py
index f9a85c73a3306e464dcc44b7cb8ae3b98f5e1d8d..ec7af0a77932b25708de186b51475696705c99ab 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_types.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_types.py
@@ -965,10 +965,14 @@ def cpp_type_has_null_value(idl_type):
# a null pointer.
# - Union types, as thier container classes can represent null value.
# - 'Object' and 'any' type. We use ScriptValue for object type.
- return (idl_type.is_string_type or idl_type.is_interface_type or
- idl_type.is_enum or idl_type.is_union_type
- or idl_type.base_type == 'object' or idl_type.base_type == 'any'
- or idl_type.is_custom_callback_function or idl_type.is_callback_interface)
+ return (idl_type.is_string_type
+ or idl_type.is_enum
+ or idl_type.is_interface_type
+ or idl_type.is_callback_interface
+ or idl_type.is_callback_function
+ or idl_type.is_custom_callback_function
+ or idl_type.is_union_type
+ or idl_type.base_type == 'object' or idl_type.base_type == 'any')
IdlTypeBase.cpp_type_has_null_value = property(cpp_type_has_null_value)

Powered by Google App Engine
This is Rietveld 408576698