Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4239)

Unified Diff: chrome/browser/content_settings/chrome_content_settings_utils.h

Issue 2588273002: Add UMA metrics for pop-up blocked page action on desktop (Closed)
Patch Set: Changed the comment of enum PopupsAction Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/content_settings/chrome_content_settings_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/content_settings/chrome_content_settings_utils.h
diff --git a/chrome/browser/content_settings/chrome_content_settings_utils.h b/chrome/browser/content_settings/chrome_content_settings_utils.h
index a787e7ab3802f65a36c14983d6abfadd31d6c934..650103f477c4a2cd186545cb001e672ae1bd91b2 100644
--- a/chrome/browser/content_settings/chrome_content_settings_utils.h
+++ b/chrome/browser/content_settings/chrome_content_settings_utils.h
@@ -38,6 +38,20 @@ enum PluginsAction {
void RecordPluginsAction(PluginsAction action);
+// UMA histogram for actions that a user can perform on the pop-up blocked page
+// action in the omnibox. The enum values correspond to histogram entries, so do
+// not remove any existing values.
+enum PopupsAction {
+ POPUPS_ACTION_DISPLAYED_BLOCKED_ICON_IN_OMNIBOX = 0,
+ POPUPS_ACTION_DISPLAYED_BUBBLE,
+ POPUPS_ACTION_SELECTED_ALWAYS_ALLOW_POPUPS_FROM,
+ POPUPS_ACTION_CLICKED_LIST_ITEM_CLICKED,
+ POPUPS_ACTION_CLICKED_MANAGE_POPUPS_BLOCKING,
+ POPUPS_ACTION_COUNT
+};
+
+void RecordPopupsAction(PopupsAction action);
+
} // namespace content_settings
#endif // CHROME_BROWSER_CONTENT_SETTINGS_CHROME_CONTENT_SETTINGS_UTILS_H_
« no previous file with comments | « no previous file | chrome/browser/content_settings/chrome_content_settings_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698