Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4870)

Unified Diff: chrome/browser/content_settings/chrome_content_settings_utils.h

Issue 2588273002: Add UMA metrics for pop-up blocked page action on desktop (Closed)
Patch Set: format fix, remove #if directive Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/chrome_content_settings_utils.h
diff --git a/chrome/browser/content_settings/chrome_content_settings_utils.h b/chrome/browser/content_settings/chrome_content_settings_utils.h
index a787e7ab3802f65a36c14983d6abfadd31d6c934..df9f36291a41acba50b0d15a0bd38045e5db5bd9 100644
--- a/chrome/browser/content_settings/chrome_content_settings_utils.h
+++ b/chrome/browser/content_settings/chrome_content_settings_utils.h
@@ -38,6 +38,20 @@ enum PluginsAction {
void RecordPluginsAction(PluginsAction action);
+// The different actions that a user can perform on the pop-up blocked page
+// action in the omnibox, The enum values back an UMA histogram, so they must be
Nico 2017/01/03 14:34:07 don't capitalize after , Also, Use the same sente
+// treated as append-only.
+enum PopupsAction {
+ POPUPS_ACTION_DISPLAYED_BLOCKED_ICON_IN_OMNIBOX = 0,
+ POPUPS_ACTION_DISPLAYED_BUBBLE,
+ POPUPS_ACTION_SELECTED_ALWAYS_ALLOW_POPUPS_FROM,
+ POPUPS_ACTION_CLICKED_LIST_ITEM_CLICKED,
+ POPUPS_ACTION_CLICKED_MANAGE_POPUPS_BLOCKING,
+ POPUPS_ACTION_COUNT
+};
+
+void RecordPopupsAction(PopupsAction action);
+
} // namespace content_settings
#endif // CHROME_BROWSER_CONTENT_SETTINGS_CHROME_CONTENT_SETTINGS_UTILS_H_

Powered by Google App Engine
This is Rietveld 408576698