Add UMA metrics for pop-up blocked page action on desktop

chrome/browser/content_settings/chrome_content_settings_utils.h

Index: chrome/browser/content_settings/chrome_content_settings_utils.h
diff --git a/chrome/browser/content_settings/chrome_content_settings_utils.h b/chrome/browser/content_settings/chrome_content_settings_utils.h
index a787e7ab3802f65a36c14983d6abfadd31d6c934..f436f1975dba0a0c523361323562f08a6a4ab860 100644
--- a/chrome/browser/content_settings/chrome_content_settings_utils.h
+++ b/chrome/browser/content_settings/chrome_content_settings_utils.h
@@ -38,6 +38,18 @@ enum PluginsAction {
 
 void RecordPluginsAction(PluginsAction action);
 
+// UMA histogram for the pop-ups broken puzzle piece. The enum values

[dominickn, 2016/12/20 05:31:48]

Nit: change the comment to be:

"The different actions that a user can perform on the pop-up blocked page action
in the omnibox, The enum values back an UMA histogram, so they must be treated
as append-only."

[charleszhao, 2016/12/20 22:43:50]

Done.

+// correspond to histogram entries, so do not remove any existing values.
+enum PopupsAction {
+  POPUPS_ACTION_DISPLAYED_BLOCKED_ICON_IN_OMNIBOX = 0,
+  POPUPS_ACTION_DISPLAYED_BUBBLE,
+  POPUPS_ACTION_SELECTED_ALWAYS_ALLOW_POPUPS_FROM,
+  POPUPS_ACTION_CLICKED_LIST_ITEM_CLICKED,
+  POPUPS_ACTION_CLICKED_MANAGE_POPUPS_BLOCKING,
+  POPUPS_ACTION_COUNT
+};
+
+void RecordPopupsAction(PopupsAction action);

[dominickn, 2016/12/20 05:31:48]

Nit: newline before the } that closes the namespace

[charleszhao, 2016/12/20 22:43:50]

Done.

 }  // namespace content_settings
 
 #endif  // CHROME_BROWSER_CONTENT_SETTINGS_CHROME_CONTENT_SETTINGS_UTILS_H_