Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Side by Side Diff: chrome/browser/content_settings/chrome_content_settings_utils.cc

Issue 2588273002: Add UMA metrics for pop-up blocked page action on desktop (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/content_settings/chrome_content_settings_utils.h" 5 #include "chrome/browser/content_settings/chrome_content_settings_utils.h"
6 6
7 #include "base/metrics/histogram_macros.h" 7 #include "base/metrics/histogram_macros.h"
8 8
9 namespace content_settings { 9 namespace content_settings {
10 10
11 void RecordMixedScriptAction(MixedScriptAction action) { 11 void RecordMixedScriptAction(MixedScriptAction action) {
12 UMA_HISTOGRAM_ENUMERATION("ContentSettings.MixedScript", action, 12 UMA_HISTOGRAM_ENUMERATION("ContentSettings.MixedScript", action,
13 MIXED_SCRIPT_ACTION_COUNT); 13 MIXED_SCRIPT_ACTION_COUNT);
14 } 14 }
15 15
16 void RecordPluginsAction(PluginsAction action) { 16 void RecordPluginsAction(PluginsAction action) {
17 UMA_HISTOGRAM_ENUMERATION("ContentSettings.Plugins", action, 17 UMA_HISTOGRAM_ENUMERATION("ContentSettings.Plugins", action,
18 PLUGINS_ACTION_COUNT); 18 PLUGINS_ACTION_COUNT);
19 } 19 }
20 20
21 void RecordPopupsAction(PopupsAction action) {
22 UMA_HISTOGRAM_ENUMERATION("ContentSettings.Popups", action,
23 POPUPS_ACTION_COUNT);
24 }
25
dominickn 2016/12/20 05:31:48 Nit: remove the extra newline here (have only one)
charleszhao 2016/12/20 22:43:50 Done.
26
21 } // namespace content_settings 27 } // namespace content_settings
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698