Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2206)

Unified Diff: chrome/browser/net/net_error_tab_helper_unittest.cc

Issue 2588253002: Enable download page action for error page (Closed)
Patch Set: Fix trybots Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/net_error_tab_helper_unittest.cc
diff --git a/chrome/browser/net/net_error_tab_helper_unittest.cc b/chrome/browser/net/net_error_tab_helper_unittest.cc
index daab84b5c63a8e8eb4b26c42b6068db2cff687fb..a594f99bc5415b6feaf7d0fc49df7ca98baeb8cc 100644
--- a/chrome/browser/net/net_error_tab_helper_unittest.cc
+++ b/chrome/browser/net/net_error_tab_helper_unittest.cc
@@ -43,7 +43,7 @@ class TestNetErrorTabHelper : public NetErrorTabHelper {
int mock_sent_count() const { return mock_sent_count_; }
#if BUILDFLAG(ANDROID_JAVA_UI)
- using NetErrorTabHelper::DownloadPageLater;
+ using NetErrorTabHelper::OnDownloadPageLater;
const GURL& download_page_later_url() const {
return download_page_later_url_;
@@ -174,7 +174,7 @@ class NetErrorTabHelperTest : public ChromeRenderViewHostTestHarness {
bool succeeded) {
GURL url(url_string);
LoadURL(url, succeeded);
- tab_helper()->DownloadPageLater();
+ tab_helper()->OnDownloadPageLater();
EXPECT_EQ(0, tab_helper()->times_download_page_later_invoked());
}
#endif
@@ -375,7 +375,7 @@ TEST_F(NetErrorTabHelperTest, NoDiagnosticsForNonHttpSchemes) {
TEST_F(NetErrorTabHelperTest, DownloadPageLater) {
GURL url("http://somewhere:123/");
LoadURL(url, false /*succeeded*/);
- tab_helper()->DownloadPageLater();
+ tab_helper()->OnDownloadPageLater();
EXPECT_EQ(url, tab_helper()->download_page_later_url());
EXPECT_EQ(1, tab_helper()->times_download_page_later_invoked());
}
@@ -383,7 +383,7 @@ TEST_F(NetErrorTabHelperTest, DownloadPageLater) {
TEST_F(NetErrorTabHelperTest, NoDownloadPageLaterOnNonErrorPage) {
GURL url("http://somewhere:123/");
LoadURL(url, true /*succeeded*/);
- tab_helper()->DownloadPageLater();
+ tab_helper()->OnDownloadPageLater();
EXPECT_EQ(0, tab_helper()->times_download_page_later_invoked());
}

Powered by Google App Engine
This is Rietveld 408576698