Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2095)

Unified Diff: chrome/browser/net/net_error_tab_helper.h

Issue 2588253002: Enable download page action for error page (Closed)
Patch Set: set false in NetErrorTabHelper::DidFinishNavigation Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/net_error_tab_helper.h
diff --git a/chrome/browser/net/net_error_tab_helper.h b/chrome/browser/net/net_error_tab_helper.h
index 90ffc5279a37e37c77274b7a44e1215426635b1d..f46b30d9e06d0830838061a4f1411241aeb76a6f 100644
--- a/chrome/browser/net/net_error_tab_helper.h
+++ b/chrome/browser/net/net_error_tab_helper.h
@@ -52,6 +52,12 @@ class NetErrorTabHelper
dns_probe_status_snoop_callback_ = dns_probe_status_snoop_callback;
}
+#if BUILDFLAG(ANDROID_JAVA_UI)
+ bool is_showing_download_button_in_error_page() const {
+ return is_showing_download_button_in_error_page_;
+ }
+#endif // BUILDFLAG(ANDROID_JAVA_
nasko 2017/01/10 17:40:22 nit: s/JAVA_/JAVA_UI)/
jianli 2017/01/10 21:35:26 Done.
+
// content::WebContentsObserver implementation.
void RenderFrameCreated(content::RenderFrameHost* render_frame_host) override;
void DidStartNavigation(
@@ -79,7 +85,8 @@ class NetErrorTabHelper
}
#if BUILDFLAG(ANDROID_JAVA_UI)
- void DownloadPageLater();
+ void OnDownloadPageLater();
+ void OnSetIsShowingDownloadButtonInErrorPage(bool is_showing_download_button);
#endif // BUILDFLAG(ANDROID_JAVA_UI)
private:
@@ -116,6 +123,11 @@ class NetErrorTabHelper
// is true. (This should never be true if |dns_error_active_| is false.)
bool dns_error_page_committed_;
+#if BUILDFLAG(ANDROID_JAVA_UI)
+ // True if download button is being shown when the error page commits.
+ bool is_showing_download_button_in_error_page_;
+#endif // BUILDFLAG(ANDROID_JAVA_UI
nasko 2017/01/10 17:40:22 nit: Still unmatched parenthesis here.
jianli 2017/01/10 21:35:26 Done.
+
// The status of a DNS probe that may or may not have started or finished.
// Since the renderer can change out from under the helper (in cross-process
// navigations), it re-sends the status whenever an error page commits.

Powered by Google App Engine
This is Rietveld 408576698