common/data/rand/mathrand/impl.go - Issue 2588213002: Use global rand.Rand instance in mathrand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: common/data/rand/mathrand/impl.go

Issue 2588213002: Use global rand.Rand instance in mathrand. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: common/data/rand/mathrand/impl.go

diff --git a/common/data/rand/mathrand/impl.go b/common/data/rand/mathrand/impl.go

index cb0cda4b6e1307d414e7984192cd469d12d66ff8..373e97f6514250903bc03ac9080959805f2c0f07 100644

--- a/common/data/rand/mathrand/impl.go

+++ b/common/data/rand/mathrand/impl.go

@@ -94,6 +94,10 @@ type Rand interface {

// for it. This can be used by callers to pull and use a *rand.Rand instance

// out of the Context safely.

+ // Other "mathrand" functions and objects MUST NOT BE USED inside the

+ // callback, as WithGoRand holds the lock to the current Rand instance, so any

+ // additional function call will deadlock.

+ //

// The callback's r must not be retained or used outside of hte scope of the

// callback.

WithGoRand(fn func(r *rand.Rand) error) error