components/security_state/core/security_state.h - Issue 2588133002: Make form-not-secure controllable as its own separate Finch feature

Unified Diff: components/security_state/core/security_state.h

Issue 2588133002: Make form-not-secure controllable as its own separate Finch feature (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/security_state/core/security_state.h

diff --git a/components/security_state/core/security_state.h b/components/security_state/core/security_state.h

index c7d36a6cb81f0fb02712035d46a2c2a20869eee5..dc46e6000c8c3d9dc2f35b309e56b6e22194c3e9 100644

--- a/components/security_state/core/security_state.h

+++ b/components/security_state/core/security_state.h

@@ -9,6 +9,7 @@

#include <memory>

#include "base/callback.h"

+#include "base/feature_list.h"

#include "base/macros.h"

#include "net/cert/cert_status_flags.h"

#include "net/cert/sct_status_flags.h"

@@ -24,6 +25,10 @@

// the form of a VisibleSecurityState struct.

namespace security_state {

+// A feature for showing a warning in autofill dropdowns for password

+// and credit cards fields on HTTP pages.

elawrence 2016/12/19 20:11:46 Is this about "HTTP pages" or "non-secure contexts

estark 2016/12/19 20:49:45 Changed to "when the top-level page is not HTTPS"

+extern const base::Feature kHttpFormWarningFeature;

// Describes the overall security state of the page.

// If you reorder, add, or delete values from this enum, you must also

@@ -216,6 +221,12 @@ void GetSecurityInfo(

IsOriginSecureCallback is_origin_secure_callback,

SecurityInfo* result);

+// Returns true if an experimental form warning about HTTP passwords and

elawrence 2016/12/19 20:11:46 Should we be explicit that this is a "warning UI"

estark 2016/12/19 20:49:45 Done.

+// credit cards is enabled. This warning can be enabled with the flag

+// --mark-non-secure-as=show-non-secure-passwords-cc-chip-and-form-warning

elawrence 2016/12/19 20:11:46 Is the "show-non-secure-passwords-cc-chip-and-form

estark 2016/12/19 20:49:45 No, forgot to update this comment. Fixed.

+// or with the field trial Feature API.

+bool IsHttpWarningInFormEnabled();

} // namespace security_state

#endif // COMPONENTS_SECURITY_STATE_SECURITY_STATE_H_