Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1990)

Unified Diff: chrome/browser/about_flags.cc

Issue 2588133002: Make form-not-secure controllable as its own separate Finch feature (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 9abac3d1ed94d4e96c4cccdae61fea2edbf8fedd..19993daea13e0b13298f7ea72938f0225c6228df 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -52,6 +52,7 @@
#include "components/omnibox/browser/omnibox_switches.h"
#include "components/password_manager/core/common/password_manager_features.h"
#include "components/proximity_auth/switches.h"
+#include "components/security_state/core/security_state.h"
#include "components/security_state/core/switches.h"
#include "components/signin/core/common/signin_switches.h"
#include "components/spellcheck/common/spellcheck_features.h"
@@ -210,11 +211,7 @@ const FeatureEntry::Choice kMarkHttpAsChoices[] = {
security_state::switches::kMarkHttpAsDangerous},
{IDS_MARK_HTTP_WITH_PASSWORDS_OR_CC_WITH_CHIP,
security_state::switches::kMarkHttpAs,
- security_state::switches::kMarkHttpWithPasswordsOrCcWithChip},
- {IDS_MARK_HTTP_WITH_PASSWORDS_OR_CC_WITH_CHIP_AND_FORM_WARNING,
- security_state::switches::kMarkHttpAs,
- security_state::switches::
- kMarkHttpWithPasswordsOrCcWithChipAndFormWarning}};
+ security_state::switches::kMarkHttpWithPasswordsOrCcWithChip}};
const FeatureEntry::Choice kDataReductionProxyLoFiChoices[] = {
{ IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
@@ -1467,6 +1464,9 @@ const FeatureEntry kFeatureEntries[] = {
#endif // OS_CHROMEOS
{"mark-non-secure-as", IDS_MARK_HTTP_AS_NAME, IDS_MARK_HTTP_AS_DESCRIPTION,
kOsAll, MULTI_VALUE_TYPE(kMarkHttpAsChoices)},
+ {"enable-http-form-warning", IDS_ENABLE_HTTP_FORM_WARNING_NAME,
+ IDS_ENABLE_HTTP_FORM_WARNING_DESCRIPTION, kOsAll,
+ FEATURE_VALUE_TYPE(security_state::kHttpFormWarningFeature)},
{"enable-site-per-process", IDS_FLAGS_SITE_PER_PROCESS_NAME,
IDS_FLAGS_SITE_PER_PROCESS_DESCRIPTION, kOsAll,
SINGLE_VALUE_TYPE(switches::kSitePerProcess)},

Powered by Google App Engine
This is Rietveld 408576698