Make form-not-secure controllable as its own separate Finch feature

components/autofill/core/browser/autofill_experiments.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_experiments.h"
 
 #include "base/command_line.h"
 #include "base/feature_list.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "components/autofill/core/browser/suggestion.h"
 #include "components/autofill/core/common/autofill_pref_names.h"
 #include "components/autofill/core/common/autofill_switches.h"
 #include "components/prefs/pref_service.h"
-#include "components/security_state/core/switches.h"
+#include "components/security_state/core/security_state.h"
 #include "components/sync/driver/sync_service.h"
 #include "components/variations/variations_associated_data.h"
 #include "google_apis/gaia/gaia_auth_util.h"
 #include "grit/components_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace autofill {
 
 const base::Feature kAutofillCreditCardAssist{
     "AutofillCreditCardAssist", base::FEATURE_DISABLED_BY_DEFAULT};
@@ skipping 191 matching lines @@
     return true;
   }
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kDisableOfferUploadCreditCards)) {
     return false;
   }
 
   return !group_name.empty() && group_name != "Disabled";
 }
 
 bool IsCreditCardAutofillHttpWarningEnabled() {

[Mathieu, 2016/12/19 20:15:49]

I think it's fine to remove this function and call security_state::IsHttp... in
the autofill code directly.

[estark, 2016/12/19 20:49:45]

Done.

-  std::string choice =
-      base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
-          security_state::switches::kMarkHttpAs);
-  return choice == security_state::switches::
-                       kMarkHttpWithPasswordsOrCcWithChipAndFormWarning;
+  return security_state::IsHttpWarningInFormEnabled();
 }
 
 }  // namespace autofill