Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 2588083002: Revert "Added ability to request zone memory information for all isolates through the VM service an… (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 3611ef82a0314e9c451f4c3800e6379eb75723f7..58ef53fefb0b940567960e1500e12d68edc410b9 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -238,9 +238,6 @@ abstract class ServiceObject {
case 'SourceLocation':
obj = new SourceLocation._empty(owner);
break;
- case '_Thread':
- obj = new Thread._empty(owner);
- break;
case 'UnresolvedSourceLocation':
obj = new UnresolvedSourceLocation._empty(owner);
break;
@@ -1504,9 +1501,6 @@ class Isolate extends ServiceObjectOwner implements M.Isolate {
List<ByteData> _chunksInProgress;
- List<Thread> get threads => _threads;
- final List<Thread> _threads = new List<Thread>();
-
void _loadHeapSnapshot(ServiceEvent event) {
if (_snapshotFetch == null || _snapshotFetch.isClosed) {
// No outstanding snapshot request. Presumably another client asked for a
@@ -1630,11 +1624,6 @@ class Isolate extends ServiceObjectOwner implements M.Isolate {
if (map['extensionRPCs'] != null) {
extensionRPCs.addAll(map['extensionRPCs']);
}
-
- threads.clear();
- if(map['threads'] != null) {
- threads.addAll(map['threads']);
- }
}
Future<TagProfile> updateTagProfile() {
@@ -3067,58 +3056,6 @@ class Sentinel extends ServiceObject implements M.Sentinel {
String get shortName => valueAsString;
}
-class Thread extends ServiceObject implements M.Thread {
- M.ThreadKind get kind => _kind;
- M.ThreadKind _kind;
- List<Zone> get zones => _zones;
- final List<Zone> _zones = new List<Zone>();
-
- Thread._empty(ServiceObjectOwner owner) : super._empty(owner);
-
- void _update(Map map, bool mapIsRef) {
- String kindString = map['kind'];
- List<Map> zoneList = map['zones'];
-
- switch(kindString) {
- case "kUnknownTask":
- _kind = M.ThreadKind.unknownTask;
- break;
- case "kMutatorTask":
- _kind = M.ThreadKind.mutatorTask;
- break;
- case "kCompilerTask":
- _kind = M.ThreadKind.compilerTask;
- break;
- case "kSweeperTask":
- _kind = M.ThreadKind.sweeperTask;
- break;
- case "kMarkerTask":
- _kind = M.ThreadKind.markerTask;
- break;
- case "kFinalizerTask":
- _kind = M.ThreadKind.finalizerTask;
- break;
- default:
- assert(false);
- }
- zones.clear();
- zoneList.forEach((zone) {
- int capacity = zone['capacity'];
- int used = zone['used'];
- zones.add(new Zone(capacity, used));
- });
- }
-}
-
-class Zone implements M.Zone {
- int get capacity => _capacity;
- int _capacity;
- int get used => _used;
- int _used;
-
- Zone(this._capacity, this._used);
-}
-
class Field extends HeapObject implements M.Field {
// Library or Class.
HeapObject dartOwner;

Powered by Google App Engine
This is Rietveld 408576698