Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 2588083002: Revert "Added ability to request zone memory information for all isolates through the VM service an… (Closed)

Created:
4 years ago by bkonyi
Modified:
4 years ago
Reviewers:
zra, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Added ability to request zone memory information for all isolates through the VM service and added tests." This reverts commit 9622f1a2dfe6aeafb6928bc9dabead5f0ecbdef5. BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/f1de9b09d776eb13bc82eca0e19e33a3cb47c214

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -145 lines) Patch
M runtime/observatory/lib/models.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/isolate.dart View 1 chunk +0 lines, -3 lines 0 comments Download
D runtime/observatory/lib/src/models/objects/thread.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D runtime/observatory/lib/src/models/objects/zone.dart View 1 chunk +0 lines, -14 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 4 chunks +0 lines, -63 lines 0 comments Download
D runtime/observatory/tests/service/get_zone_memory_info_rpc_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bkonyi
Temporary revert while I fix the issues in last commit.
4 years ago (2016-12-19 18:27:39 UTC) #2
zra
lgtm
4 years ago (2016-12-19 18:31:06 UTC) #3
bkonyi
4 years ago (2016-12-19 18:31:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f1de9b09d776eb13bc82eca0e19e33a3cb47c214 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698