Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc

Issue 2587993002: Chromad: Switch AuthPolicyClient to use cros_system_api enums. (Closed)
Patch Set: add return into case statement. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
index 04bfa094866907afe74566ae2b705924915fc548..0d1988b2b4258160994e0b5e524d02611a245ebf 100644
--- a/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
@@ -564,13 +564,35 @@ void EnrollmentScreenHandler::OnPasswordPipeReady(
void EnrollmentScreenHandler::HandleAdDomainJoin(
const std::string& machine_name,
const std::string& user_name,
- int code) {
- if (code == 0) {
- controller_->OnAdJoined(gaia::ExtractDomainName(user_name));
- return;
+ authpolicy::ErrorType code) {
+ switch (code) {
+ case authpolicy::ERROR_NONE:
+ controller_->OnAdJoined(gaia::ExtractDomainName(user_name));
+ return;
+ case authpolicy::ERROR_UNKNOWN:
+ case authpolicy::ERROR_DBUS_FAILURE:
+ case authpolicy::ERROR_PARSE_UPN_FAILED:
+ case authpolicy::ERROR_BAD_USER_NAME:
+ case authpolicy::ERROR_BAD_PASSWORD:
+ case authpolicy::ERROR_PASSWORD_EXPIRED:
+ case authpolicy::ERROR_CANNOT_RESOLVE_KDC:
+ case authpolicy::ERROR_KINIT_FAILED:
+ case authpolicy::ERROR_NET_FAILED:
+ case authpolicy::ERROR_SMBCLIENT_FAILED:
+ case authpolicy::ERROR_PARSE_FAILED:
+ case authpolicy::ERROR_PARSE_PREG_FAILED:
+ case authpolicy::ERROR_BAD_GPOS:
+ case authpolicy::ERROR_LOCAL_IO:
+ case authpolicy::ERROR_NOT_JOINED:
+ case authpolicy::ERROR_NOT_LOGGED_IN:
+ case authpolicy::ERROR_STORE_POLICY_FAILED:
+ // TODO(rsorokin): Add passing/displaying error codes. (see
+ // crbug.com/659984)
+ CallJS("invalidateAd", machine_name, user_name);
+ return;
+ default:
+ NOTREACHED();
stevenjb 2016/12/28 18:12:43 As mentioned, either make this LOG(WARNING) or rem
Roman Sorokin (ftl) 2016/12/29 07:21:42 Done.
}
- // TODO(rsorokin): Add passing/displaying error codes. (see crbug.com/659984)
- CallJS("invalidateAd", machine_name, user_name);
}
void EnrollmentScreenHandler::HandleRetry() {

Powered by Google App Engine
This is Rietveld 408576698