Chromad: Switch AuthPolicyClient to use cros_system_api enums.

chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.h"
 
 #include <algorithm>
 
 #include "ash/common/system/chromeos/devicetype_utils.h"
 #include "base/bind.h"
@@ skipping 546 matching lines @@
                        password_fd.get(),
                        base::Bind(&EnrollmentScreenHandler::HandleAdDomainJoin,
                                   weak_ptr_factory_.GetWeakPtr(),
                                   machine_name,
                                   user_name));
 }
 
 void EnrollmentScreenHandler::HandleAdDomainJoin(
     const std::string& machine_name,
     const std::string& user_name,
-    int code) {
-  if (code == 0) {
-    controller_->OnAdJoined(gaia::ExtractDomainName(user_name));
-    return;
+    authpolicy::ErrorType code) {
+  switch (code) {
+    case authpolicy::ERROR_NONE:
+      controller_->OnAdJoined(gaia::ExtractDomainName(user_name));
+      return;
+    default:

[stevenjb, 2016/12/27 17:52:26]

We should list the unhandled cases explicitly and return here and not have a
default, then the compiler will complain if a new unhandled case is added. We
can also add NOTREACHED() after the switch.

[Roman Sorokin (ftl), 2016/12/28 11:04:09]

I think it's better to put NOTREACHED() after the default statement. That way
rolling out new cases from chromeos repo won't break chrome build. WDYT?

+      // TODO(rsorokin): Add passing/displaying error codes. (see
+      // crbug.com/659984)
+      CallJS("invalidateAd", machine_name, user_name);
   }
-  // TODO(rsorokin): Add passing/displaying error codes. (see crbug.com/659984)
-  CallJS("invalidateAd", machine_name, user_name);
 }
 
 void EnrollmentScreenHandler::HandleRetry() {
   DCHECK(controller_);
   controller_->OnRetry();
 }
 
 void EnrollmentScreenHandler::HandleFrameLoadingCompleted() {
   if (network_state_informer_->state() != NetworkStateInformer::ONLINE)
     return;
@@ skipping 50 matching lines @@
 
   ShowScreenWithData(OobeScreen::SCREEN_OOBE_ENROLLMENT, &screen_data);
   if (first_show_) {
     first_show_ = false;
     UpdateStateInternal(NetworkError::ERROR_REASON_UPDATE, true);
   }
   histogram_helper_->OnScreenShow();
 }
 
 }  // namespace chromeos