Chromad: Switch AuthPolicyClient to use cros_system_api enums.

chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.h"
 
 #include <algorithm>
 
 #include "ash/common/system/chromeos/devicetype_utils.h"
 #include "base/bind.h"
@@ skipping 567 matching lines @@
                        password_fd.get(),
                        base::Bind(&EnrollmentScreenHandler::HandleAdDomainJoin,
                                   weak_ptr_factory_.GetWeakPtr(),
                                   machine_name,
                                   user_name));
 }
 
 void EnrollmentScreenHandler::HandleAdDomainJoin(
     const std::string& machine_name,
     const std::string& user_name,
-    int code) {
-  if (code == 0) {
-    controller_->OnAdJoined(gaia::ExtractDomainName(user_name));
-    return;
+    authpolicy::ADJoinErrorType code) {

[Alexander Alekseev, 2016/12/21 14:45:30]

nit: please document here that code may be outside of
authpolicy::ADJoinErrorType domain because this value actually comes from DBUS
integer value . (Probably this is the reason you are using default: clause
here.)

[stevenjb, 2016/12/21 18:12:11]

authpolicy::ADJoinErrorType is a DBus constant, so that shouldn't be possible.
If we are concerned about that, we could test for that when we cast the integer
in the dbus code. We shouldn't have to document that in the implementation code,
that kind of defeats the purpose of using an enum.

[Roman Sorokin (ftl), 2016/12/23 10:03:04]

I added _COUNT member to the enum and check if the number we got from D-BUS is
within range.

+  switch (code) {
+    case authpolicy::AD_JOIN_ERROR_NONE:
+      controller_->OnAdJoined(gaia::ExtractDomainName(user_name));
+      return;
+    default:
+      // TODO(rsorokin): Add passing/displaying error codes. (see
+      // crbug.com/659984)
+      CallJS("invalidateAd", machine_name, user_name);
   }
-  // TODO(rsorokin): Add passing/displaying error codes. (see crbug.com/659984)
-  CallJS("invalidateAd", machine_name, user_name);
 }
 
 void EnrollmentScreenHandler::HandleRetry() {
   DCHECK(controller_);
   controller_->OnRetry();
 }
 
 void EnrollmentScreenHandler::HandleFrameLoadingCompleted() {
   if (network_state_informer_->state() != NetworkStateInformer::ONLINE)
     return;
@@ skipping 50 matching lines @@
 
   ShowScreenWithData(OobeScreen::SCREEN_OOBE_ENROLLMENT, &screen_data);
   if (first_show_) {
     first_show_ = false;
     UpdateStateInternal(NetworkError::ERROR_REASON_UPDATE, true);
   }
   histogram_helper_->OnScreenShow();
 }
 
 }  // namespace chromeos