Issue 258793006: Suppress Errors for chrome.alarm.get

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 258793006: Suppress Errors for chrome.alarm.get (Closed)

Created:
6 years, 8 months ago by robliao

Modified:
6 years, 8 months ago

Reviewers:
Matt Perry, not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, skare_, rgustafson

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Suppress Errors for chrome.alarm.get Removed the error signalling to prevent log spam from the runtime.lastError checks for non-existent alarms. BUG=367136 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266352

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -8 lines)			Patch
	M	chrome/browser/extensions/api/alarms/alarms_api.cc	View		2 chunks	+1 line, -5 lines	0 comments	Download
	M	chrome/browser/extensions/api/alarms/alarms_api_unittest.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 9 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/258793006/1

6 years, 8 months ago (2014-04-25 22:05:09 UTC) #8

Message was sent while issue was closed.

Change committed as 266352