Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: content/browser/frame_host/interstitial_page_impl.cc

Issue 258793004: Dragging shouldn't block interstitial page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed NOTREACHED to DVLOG. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/interstitial_page_impl.h" 5 #include "content/browser/frame_host/interstitial_page_impl.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 855 matching lines...) Expand 10 before | Expand all | Expand 10 after
866 NOTREACHED() << "InterstitialPage does not support showing popup menus."; 866 NOTREACHED() << "InterstitialPage does not support showing popup menus.";
867 } 867 }
868 #endif 868 #endif
869 869
870 void InterstitialPageImpl::InterstitialPageRVHDelegateView::StartDragging( 870 void InterstitialPageImpl::InterstitialPageRVHDelegateView::StartDragging(
871 const DropData& drop_data, 871 const DropData& drop_data,
872 WebDragOperationsMask allowed_operations, 872 WebDragOperationsMask allowed_operations,
873 const gfx::ImageSkia& image, 873 const gfx::ImageSkia& image,
874 const gfx::Vector2d& image_offset, 874 const gfx::Vector2d& image_offset,
875 const DragEventSourceInfo& event_info) { 875 const DragEventSourceInfo& event_info) {
876 NOTREACHED() << "InterstitialPage does not support dragging yet."; 876 interstitial_page_->render_view_host_->DragSourceSystemDragEnded();
877 DVLOG(1) << "InterstitialPage does not support dragging yet.";
877 } 878 }
878 879
879 void InterstitialPageImpl::InterstitialPageRVHDelegateView::UpdateDragCursor( 880 void InterstitialPageImpl::InterstitialPageRVHDelegateView::UpdateDragCursor(
880 WebDragOperation) { 881 WebDragOperation) {
881 NOTREACHED() << "InterstitialPage does not support dragging yet."; 882 NOTREACHED() << "InterstitialPage does not support dragging yet.";
882 } 883 }
883 884
884 void InterstitialPageImpl::InterstitialPageRVHDelegateView::GotFocus() { 885 void InterstitialPageImpl::InterstitialPageRVHDelegateView::GotFocus() {
885 WebContents* web_contents = interstitial_page_->web_contents(); 886 WebContents* web_contents = interstitial_page_->web_contents();
886 if (web_contents && web_contents->GetDelegate()) 887 if (web_contents && web_contents->GetDelegate())
(...skipping 11 matching lines...) Expand all
898 899
899 web_contents->GetDelegateView()->TakeFocus(reverse); 900 web_contents->GetDelegateView()->TakeFocus(reverse);
900 } 901 }
901 902
902 void InterstitialPageImpl::InterstitialPageRVHDelegateView::OnFindReply( 903 void InterstitialPageImpl::InterstitialPageRVHDelegateView::OnFindReply(
903 int request_id, int number_of_matches, const gfx::Rect& selection_rect, 904 int request_id, int number_of_matches, const gfx::Rect& selection_rect,
904 int active_match_ordinal, bool final_update) { 905 int active_match_ordinal, bool final_update) {
905 } 906 }
906 907
907 } // namespace content 908 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698