Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4870)

Unified Diff: chrome/test/data/webui/cr_elements/cr_slider_tests.js

Issue 2587913007: MD Settings: cr-slider: Make display consistent and clean up. (Closed)
Patch Set: Update tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/cr_elements/cr_slider_tests.js
diff --git a/chrome/test/data/webui/cr_elements/cr_slider_tests.js b/chrome/test/data/webui/cr_elements/cr_slider_tests.js
index 5147c264f0d3799634f588ea0bc734886117668d..1df3a181be1c278f05ab30821042d9743328ab9a 100644
--- a/chrome/test/data/webui/cr_elements/cr_slider_tests.js
+++ b/chrome/test/data/webui/cr_elements/cr_slider_tests.js
@@ -24,20 +24,6 @@ cr.define('cr_slider', function() {
paperSlider = slider.$$('paper-slider');
});
- test('basic properties', function() {
- // Default properties.
- expectEquals(1, paperSlider.step);
- expectEquals(0, paperSlider.min);
-
- // Configurable properties.
- expectFalse(paperSlider.snaps);
- slider.setAttribute('snaps', '');
- expectTrue(paperSlider.snaps);
-
- slider.setAttribute('max-markers', 7);
- expectEquals(7, paperSlider.maxMarkers);
- });
-
test('set value', function() {
slider.tickValues = tickValues;
slider.value = 16;
@@ -45,18 +31,18 @@ cr.define('cr_slider', function() {
expectEquals(3, paperSlider.value);
expectEquals(3, paperSlider.immediateValue);
- // Setting to an in-between value should choose an index but not change
- // the value.
+ // cr-slider only supports snapping to a range of tick values. Setting
+ // to an in-between value should snap to an indexed value.
slider.value = 70;
expectEquals(5, paperSlider.value);
expectEquals(5, paperSlider.immediateValue);
- expectEquals(70, slider.value);
+ expectEquals(64, slider.value);
// Setting the value out-of-range should clamp the slider.
slider.value = -100;
expectEquals(0, paperSlider.value);
expectEquals(0, paperSlider.immediateValue);
- expectEquals(-100, slider.value);
+ expectEquals(2, slider.value);
});
test('move slider', function() {
« no previous file with comments | « chrome/browser/resources/settings/settings_shared_css.html ('k') | chrome/test/data/webui/settings/device_page_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698