Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: chrome/browser/resources/settings/device_page/keyboard.html

Issue 2587913007: MD Settings: cr-slider: Make display consistent and clean up. (Closed)
Patch Set: Update tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/device_page/keyboard.html
diff --git a/chrome/browser/resources/settings/device_page/keyboard.html b/chrome/browser/resources/settings/device_page/keyboard.html
index cb7b630674f6348b08f6c121854225f8524ed36e..5b6473a88a57aec0dbe55ea1d63cc7aed89088fd 100644
--- a/chrome/browser/resources/settings/device_page/keyboard.html
+++ b/chrome/browser/resources/settings/device_page/keyboard.html
@@ -2,7 +2,6 @@
<link rel="import" href="chrome://resources/html/cr.html">
<link rel="import" href="chrome://resources/html/polymer.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-collapse.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-flex-layout-classes.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button-light.html">
<link rel="import" href="/controls/settings_checkbox.html">
<link rel="import" href="/controls/settings_dropdown_menu.html">
@@ -83,29 +82,28 @@
opened="[[prefs.settings.language.xkb_auto_repeat_enabled_r2.value]]">
<div class="settings-box continuation settings-checkbox-spacer">
<div class="start" id="repeatDelayLabel">$i18n{keyRepeatDelay}</div>
- <div class="layout horizontal center">
- <div>$i18n{keyRepeatDelayLong}</div>
- <cr-slider id="delaySlider" class="always-on" snaps
- value="{{prefs.settings.language.xkb_auto_repeat_delay_r2.value}}"
- tick-values="[[autoRepeatDelays_]]"
- disabled="[[!prefs.settings.language.xkb_auto_repeat_enabled_r2.value]]"
- aria-labelledby="repeatDelayLabel">
- </cr-slider>
- <div>$i18n{keyRepeatDelayShort}</div>
- </div>
+ <cr-slider id="delaySlider"
+ value="{{prefs.settings.language.xkb_auto_repeat_delay_r2.value}}"
+ tick-values="[[autoRepeatDelays_]]"
+ disabled="[[
+ !prefs.settings.language.xkb_auto_repeat_enabled_r2.value]]"
+ aria-labelledby="repeatDelayLabel"
+ label-min="$i18n{keyRepeatDelayLong}"
+ label-max="$i18n{keyRepeatDelayShort}">
+ </cr-slider>
</div>
<div class="settings-box continuation settings-checkbox-spacer">
<div class="start" id="repeatRateLabel">$i18n{keyRepeatRate}</div>
- <div class="layout horizontal center">
- <div>$i18n{keyRepeatRateSlow}</div>
- <cr-slider id="repeatRateSlider" class="always-on" snaps
- value="{{prefs.settings.language.xkb_auto_repeat_interval_r2.value}}"
- tick-values="[[autoRepeatIntervals_]]"
- disabled="[[!prefs.settings.language.xkb_auto_repeat_enabled_r2.value]]"
- aria-labelledby="repeatRateLabel">
- </cr-slider>
- <div>$i18n{keyRepeatRateFast}</div>
- </div>
+ <cr-slider id="repeatRateSlider"
+ value="{{
+ prefs.settings.language.xkb_auto_repeat_interval_r2.value}}"
+ tick-values="[[autoRepeatIntervals_]]"
+ disabled="[[
+ !prefs.settings.language.xkb_auto_repeat_enabled_r2.value]]"
+ aria-labelledby="repeatRateLabel"
+ label-min="$i18n{keyRepeatRateSlow}"
+ label-max="$i18n{keyRepeatRateFast}">
+ </cr-slider>
</div>
</iron-collapse>
<div id="keyboardOverlay" class="settings-box"
« no previous file with comments | « chrome/browser/resources/settings/device_page/display.js ('k') | chrome/browser/resources/settings/device_page/pointers.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698