Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8699)

Unified Diff: chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc

Issue 258783006: [fsp] Add the getMetadata operation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
diff --git a/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc b/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
index fe25c44b1c22613cd9087a28d01a8330ffcdb593..3bec92d4099a2a20df43e83cde5449d26b539c96 100644
--- a/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
+++ b/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
@@ -107,6 +107,8 @@ bool FileSystemProviderMountFunction::RunSync() {
Service* service = Service::Get(GetProfile());
DCHECK(service);
+ if (!service)
+ return false;
int file_system_id =
service->MountFileSystem(extension_id(), params->display_name);
@@ -132,11 +134,13 @@ bool FileSystemProviderMountFunction::RunSync() {
bool FileSystemProviderUnmountFunction::RunSync() {
using api::file_system_provider::Unmount::Params;
- const scoped_ptr<Params> params(Params::Create(*args_));
+ scoped_ptr<Params> params(Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params);
Service* service = Service::Get(GetProfile());
DCHECK(service);
+ if (!service)
+ return false;
if (!service->UnmountFileSystem(extension_id(), params->file_system_id)) {
// TODO(mtomasz): Pass more detailed errors, rather than just a bool.
@@ -158,6 +162,8 @@ bool FileSystemProviderInternalUnmountRequestedSuccessFunction::RunSync() {
Service* service = Service::Get(GetProfile());
DCHECK(service);
+ if (!service)
+ return false;
ProvidedFileSystemInterface* file_system =
service->GetProvidedFileSystem(extension_id(), params->file_system_id);
@@ -197,6 +203,89 @@ bool FileSystemProviderInternalUnmountRequestedErrorFunction::RunSync() {
Service* service = Service::Get(GetProfile());
DCHECK(service);
+ if (!service)
+ return false;
+
+ ProvidedFileSystemInterface* file_system =
+ service->GetProvidedFileSystem(extension_id(), params->file_system_id);
+ if (!file_system) {
+ base::ListValue* result = new base::ListValue();
+ result->Append(
+ CreateError(kNotFoundErrorName, kResponseFailedErrorMessage));
+ SetResult(result);
+ return false;
+ }
+
+ RequestManager* request_manager = file_system->GetRequestManager();
+ DCHECK(request_manager);
+
+ if (!request_manager->RejectRequest(
+ params->request_id, ProviderErrorToFileError(params->error))) {
+ // TODO(mtomasz): Pass more detailed errors, rather than just a bool.
+ base::ListValue* result = new base::ListValue();
+ result->Append(
+ CreateError(kSecurityErrorName, kResponseFailedErrorMessage));
+ SetResult(result);
+ return false;
+ }
+
+ base::ListValue* result = new base::ListValue();
+ SetResult(result);
+ return true;
+}
+
+bool FileSystemProviderInternalGetMetadataRequestedSuccessFunction::RunSync() {
+ // TODO(mtomasz): Create a common class for these internal functions so
+ // most of the code could be easily reused.
+ using api::file_system_provider_internal::GetMetadataRequestedSuccess::Params;
+ scoped_ptr<Params> params(Params::Create(*args_));
+ EXTENSION_FUNCTION_VALIDATE(params);
+
+ Service* service = Service::Get(GetProfile());
+ DCHECK(service);
+ if (!service)
+ return false;
+
+ ProvidedFileSystemInterface* file_system =
+ service->GetProvidedFileSystem(extension_id(), params->file_system_id);
+ if (!file_system) {
+ base::ListValue* result = new base::ListValue();
+ result->Append(
+ CreateError(kNotFoundErrorName, kResponseFailedErrorMessage));
+ SetResult(result);
+ return false;
+ }
+
+ RequestManager* request_manager = file_system->GetRequestManager();
+ DCHECK(request_manager);
+
+ const int request_id = params->request_id;
+ if (!request_manager->FulfillRequest(
+ request_id,
+ RequestValue::CreateForGetMetadataSuccess(params.Pass()),
+ false /* has_more */)) {
+ // TODO(mtomasz): Pass more detailed errors, rather than just a bool.
+ base::ListValue* result = new base::ListValue();
+ result->Append(
+ CreateError(kSecurityErrorName, kResponseFailedErrorMessage));
+ SetResult(result);
+ return false;
+ }
+
+ base::ListValue* result = new base::ListValue();
+ SetResult(result);
+ return true;
+}
+
+bool FileSystemProviderInternalGetMetadataRequestedErrorFunction::RunSync() {
+ using api::file_system_provider_internal::UnmountRequestedError::Params;
+ const scoped_ptr<Params> params(Params::Create(*args_));
+ EXTENSION_FUNCTION_VALIDATE(params);
+
+ Service* service = Service::Get(GetProfile());
+ DCHECK(service);
+ if (!service)
+ return false;
ProvidedFileSystemInterface* file_system =
service->GetProvidedFileSystem(extension_id(), params->file_system_id);

Powered by Google App Engine
This is Rietveld 408576698