[fsp] Add the getMetadata operation.

chrome/common/extensions/api/file_system_provider.idl

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Use the <code>chrome.fileSystemProvider</code> API to create file systems,
 // that can be accessible from the file manager on Chrome OS.
 [platforms=("chromeos"),
  implemented_in="chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h"]
 namespace fileSystemProvider {
   // Error codes used by providing extensions in response to requests. For
@@ skipping 11 matching lines @@
     NOT_A_DIRECTORY,
     INVALID_OPERATION,
     SECURITY,
     ABORT,
     NOT_A_FILE,
     NOT_EMPTY,
     INVALID_URL,
     IO
   };
 
+  // Represents metadata of a file or a directory.
+  dictionary EntryMetadata {
+    // True if it is a directory.
+    boolean isDirectory;
+
+    // Name of this entry (not full path name).
+    DOMString name;

[benwells, 2014/04/30 07:04:34]

Maybe this should this be called baseName?

[mtomasz, 2014/04/30 09:18:24]

It follows HTML5 FileEntry specs. It is called there 'name'.

+
+    // File size in bytes.
+    double size;

[benwells, 2014/04/30 07:04:34]

Is this because long isn't big enough?

[mtomasz, 2014/04/30 09:18:24]

Exactly yes. We had this issue in Files app.

+
+    // The last modified time of this entry.
+    [instanceOf=Date] object modificationTime;
+  };
+
   // Callback to receive the result of mount() function.
   // <code>fileSystemID</code> will be a unique ID for the file system just
   // mounted. The ID is used to distinguish multiple file systems mounted
   // from a single File System Provider.
   callback MountCallback = void(long fileSystemId,
                                 [nodoc, instanceOf=DOMError] object error);
 
 
   // Callback to receive the result of unmount() function with the <code>
   // fileSystemId</code> identifier.
   callback UnmountCallback = void(long fileSystemId,
                                   [nodoc, instanceOf=DOMError] object error);
 
   // Callback to be called by the providing extension in case of a success.
   callback ProviderSuccessCallback = void();
 
   // Callback to be called by the providing extension in case of an error.
   callback ProviderErrorCallback = void(ProviderError error);
 
   // Callback to handle an error raised from the browser.
   [nocompile] callback ErrorCallback = void([instanceOf=DOMError] object error);
 
+  // Success callback for the <code>onGetMetadataRequested</code> event.
+  callback MetadataCallback = void(EntryMetadata metadata);
+
   interface Functions {
     // Mounts a file system with the given <code>displayName</code>.
     // <code>displayName</code> will be shown in the left panel of
     // Files.app. <code>displayName</code> can contain any characters
     // including '/', but cannot be an empty string. <code>displayName</code>
     // should be descriptive but doesn't have to be unique. Duplicate display
     // names are uniquified by adding suffix like "(1)" in the Files.app UI.
     static void mount(DOMString displayName,
                       MountCallback successCallback,
                       [nocompile] ErrorCallback errorCallback);
@@ skipping 12 matching lines @@
   interface Events {
     // Raised, when the user requests unmounting of the file system with the
     // <code>fileSystemId</code> identifier in the Files.app UI. In response,
     // the <code>unmount</code> API method should be called. If unmounting is
     // not possible (eg. due to pending operation), then <code>errorCallback
     // </code> should be called, and <code>unmount</code> should not be called.
     [maxListeners=1] static void onUnmountRequested(
         long fileSystemId,
         ProviderSuccessCallback successCallback,
         ProviderErrorCallback errorCallback);
+
+    // Raised, when the user requests metadat for a file or a directory at

[benwells, 2014/04/30 07:04:34]

It feels weird to explicitly mention the user here (and also for
onUnmountRequested). I assume the system could also request these things, or
some app. Could this just be 'Raised when something requests...' or 'Raised when
the system needs...' (also note lack of comma after Raised).

Also, s/metadat/metadata/

[mtomasz, 2014/04/30 09:18:24]

Good point. Done.

+    // <code>entryPath</code>. In case of an error, <code>errorCallback</code>
+    // must be called.
+    [maxListeners=1] static void onGetMetadataRequested(
+        long fileSystemId,
+        DOMString entryPath,
+        MetadataCallback successCallback,
+        ErrorCallback errorCallback);
   };
 };