Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 258783005: Revert of teach TSAN about SkSpinlock, SkRefCnt, and SkOnce (Closed)

Created:
6 years, 8 months ago by mtklein
Modified:
6 years, 8 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of teach TSAN about SkSpinlock, SkRefCnt, and SkOnce (https://codereview.chromium.org/247813005/) Reason for revert: breaks blink in roll Original issue's description: > teach TSAN about SkSpinlock, SkRefCnt, and SkOnce > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14353 > > NOTRY=true > NOTREECHECKS=true > > Committed: http://code.google.com/p/skia/source/detail?r=14354 TBR=bsalomon@google.com,bungeman@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/core/SkRefCnt.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of teach TSAN about SkSpinlock, SkRefCnt, and SkOnce
6 years, 8 months ago (2014-04-27 19:14:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/258783005/1
6 years, 8 months ago (2014-04-27 19:14:33 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-27 19:14:49 UTC) #3
Message was sent while issue was closed. 
Change committed as 14389

Powered by Google App Engine
This is Rietveld 408576698