Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 258783002: Extracted UsbService as interface. (Closed)

Created:
6 years, 8 months ago by Dmitry Zvorygin
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Extracted UsbService as interface. Introduced UsbServiceImpl class. Reworked USB Extensions API tests. BUG=367094 R=pfeldman@chromium.org, rockot@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268172

Patch Set 1 #

Patch Set 2 : Fixed style in manifests. #

Total comments: 2

Patch Set 3 : Rebased and fixed minor comment. #

Patch Set 4 : Made private inheritance public. #

Patch Set 5 : Initialized class field. #

Patch Set 6 : Fixed chromeos issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -232 lines) Patch
M chrome/browser/extensions/api/usb/usb_api.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/usb/usb_api.cc View 5 chunks +0 lines, -27 lines 0 comments Download
M chrome/browser/extensions/api/usb/usb_apitest.cc View 1 2 3 4 5 7 chunks +67 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/usb/device_handling/manifest.json View 1 1 chunk +9 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/usb/invalid_length_transfer/manifest.json View 1 1 chunk +9 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/usb/list_interfaces/manifest.json View 1 chunk +9 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/usb/reset_device/manifest.json View 1 chunk +9 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/usb/transfer_event/manifest.json View 1 chunk +9 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/usb/transfer_failure/manifest.json View 1 chunk +9 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/usb/zero_length_transfer/manifest.json View 1 chunk +9 lines, -1 line 0 comments Download
M components/usb_service.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/usb_service/usb_context.h View 1 chunk +1 line, -1 line 0 comments Download
M components/usb_service/usb_device.h View 1 chunk +1 line, -1 line 0 comments Download
M components/usb_service/usb_interface.h View 1 chunk +8 lines, -3 lines 0 comments Download
M components/usb_service/usb_interface.cc View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M components/usb_service/usb_service.h View 1 2 3 1 chunk +8 lines, -39 lines 0 comments Download
D components/usb_service/usb_service.cc View 1 chunk +0 lines, -126 lines 0 comments Download
A + components/usb_service/usb_service_impl.cc View 1 2 5 chunks +64 lines, -22 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
Dmitry Zvorygin
Please take a look.
6 years, 8 months ago (2014-04-25 12:24:00 UTC) #1
pfeldman
lgtm
6 years, 8 months ago (2014-04-25 15:17:30 UTC) #2
pfeldman
https://codereview.chromium.org/258783002/diff/20001/components/usb_service/usb_service.h File components/usb_service/usb_service.h (right): https://codereview.chromium.org/258783002/diff/20001/components/usb_service/usb_service.h#newcode23 components/usb_service/usb_service.h:23: class USB_SERVICE_EXPORT UsbService : protected base::NonThreadSafe { Why protected?
6 years, 8 months ago (2014-04-25 15:23:40 UTC) #3
Ken Rockot(use gerrit already)
LGTM https://codereview.chromium.org/258783002/diff/20001/components/usb_service/usb_service_impl.cc File components/usb_service/usb_service_impl.cc (right): https://codereview.chromium.org/258783002/diff/20001/components/usb_service/usb_service_impl.cc#newcode30 components/usb_service/usb_service_impl.cc:30: class USB_SERVICE_EXPORT UsbServiceImpl You can remove the EXPORT ...
6 years, 8 months ago (2014-04-25 15:30:22 UTC) #4
Dmitry Zvorygin
On 2014/04/25 15:23:40, pfeldman wrote: > https://codereview.chromium.org/258783002/diff/20001/components/usb_service/usb_service.h > File components/usb_service/usb_service.h (right): > > https://codereview.chromium.org/258783002/diff/20001/components/usb_service/usb_service.h#newcode23 > ...
6 years, 7 months ago (2014-04-29 11:07:01 UTC) #5
Dmitry Zvorygin
The CQ bit was checked by zvorygin@chromium.org
6 years, 7 months ago (2014-04-29 11:13:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zvorygin@chromium.org/258783002/40001
6 years, 7 months ago (2014-04-29 11:13:12 UTC) #7
pfeldman
The CQ bit was unchecked by pfeldman@chromium.org
6 years, 7 months ago (2014-04-29 11:21:42 UTC) #8
pfeldman
> What for make it public? http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Inheritance
6 years, 7 months ago (2014-04-29 11:22:31 UTC) #9
Dmitry Zvorygin
On 2014/04/29 11:22:31, pfeldman wrote: > > What for make it public? > > http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Inheritance ...
6 years, 7 months ago (2014-04-29 11:40:41 UTC) #10
Dmitry Zvorygin
The CQ bit was checked by zvorygin@chromium.org
6 years, 7 months ago (2014-04-29 11:40:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zvorygin@chromium.org/258783002/60001
6 years, 7 months ago (2014-04-29 11:41:08 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 11:55:22 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-29 11:55:23 UTC) #14
Dmitry Zvorygin
The CQ bit was checked by zvorygin@chromium.org
6 years, 7 months ago (2014-04-30 15:08:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zvorygin@chromium.org/258783002/80001
6 years, 7 months ago (2014-04-30 15:09:03 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 15:12:06 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 15:12:06 UTC) #18
Dmitry Zvorygin
The CQ bit was checked by zvorygin@chromium.org
6 years, 7 months ago (2014-04-30 17:06:53 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zvorygin@chromium.org/258783002/100001
6 years, 7 months ago (2014-04-30 17:07:45 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 17:22:53 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 17:22:54 UTC) #22
Dmitry Zvorygin
6 years, 7 months ago (2014-05-05 13:58:12 UTC) #23
Message was sent while issue was closed. 
Committed patchset #6 manually as r268172 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698