Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 25877002: Don't evaluate the argument twice for unresolved static setter calls. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Change status for VM and dart2dart. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/co19/co19-co19.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
index 70713dad882d0a1001d0ca5d9df52d3f68575730..1a595d3d102f17b83e36668f3b6bf17dcaf37575 100644
--- a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
+++ b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
@@ -2719,7 +2719,8 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
generateThrowNoSuchMethod(
location,
getTargetName(element, 'set'),
- argumentNodes: (send == null ? const Link<Node>() : send.arguments));
+ argumentValues: (send == null ? <HInstruction>[] :
kasperl 2013/10/04 07:30:27 I'd compute the argument values outside the call t
karlklose 2013/10/04 08:46:55 Done.
+ <HInstruction>[value]));
} else {
stack.add(value);
// If the value does not already have a name, give it here.
« no previous file with comments | « no previous file | tests/co19/co19-co19.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698