Include source in kernel.

pkg/kernel/lib/analyzer/loader.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 library kernel.analyzer.loader;
 
 import 'dart:async';
 import 'dart:io' as io;
 
 import 'package:analyzer/analyzer.dart';
 import 'package:analyzer/file_system/file_system.dart';
@@ skipping 314 matching lines @@
                   : mixinType.typeArguments);
         } else {
           // Generate a new class specific for this mixin application.
           var freshParameters =
               getFreshTypeParameters(classNode.typeParameters);
           var mixinClass = new ast.Class(
               name: '${classNode.name}^${mixinType.classNode.name}',
               isAbstract: true,
               typeParameters: freshParameters.freshTypeParameters,
               supertype: freshParameters.substituteSuper(supertype),
-              mixedInType: freshParameters.substituteSuper(mixinType));
+              mixedInType: freshParameters.substituteSuper(mixinType),
+              fileUri: "file://${element.source.fullName}");

[Kevin Millikin (Google), 2016/12/20 12:03:33]

fileUri: classNode.fileUri

[jensj, 2016/12/20 13:30:22]

Done.

           mixinClass.level = ast.ClassLevel.Type;
           supertype = new ast.Supertype(mixinClass,
               classNode.typeParameters.map(makeTypeParameterType).toList());
           addMixinClassToLibrary(mixinClass, classNode.enclosingLibrary);
           // This class cannot be used from anywhere else, so don't try to
           // generate shared mixin applications using it.
           useSharedMixin = false;
         }
       }
       classNode.supertype = supertype;
@@ skipping 233 matching lines @@
           : typeArguments;
       var mixinArgs = typeArguments.length != mixedInClass.typeParameters.length
           ? typeArguments.sublist(0, mixedInClass.typeParameters.length)
           : typeArguments;
       var result = new ast.Class(
           name: name,
           isAbstract: true,
           typeParameters: fresh.freshTypeParameters,
           supertype: new ast.Supertype(superclass, superArgs),
           mixedInType: new ast.Supertype(mixedInClass, mixinArgs),
-          fileUri: mixedInClass.fileUri);
+          fileUri: library.fileUri);
       result.level = ast.ClassLevel.Type;
       library.addClass(result);
       return result;
     });
   }
 
   String formatErrorMessage(
       AnalysisError error, String filename, LineInfo lines) {
     var location = lines.getLocation(error.offset);
     return '[error] ${error.message} ($filename, '
@@ skipping 87 matching lines @@
     loadEverything(target: target, compileSdk: compileSdk);
     var program = new ast.Program(repository.libraries);
     program.mainMethod = library.procedures.firstWhere(
         (member) => member.name?.name == 'main',
         orElse: () => null);
     for (LibraryElement libraryElement in libraryElements) {
       for (CompilationUnitElement compilationUnitElement
           in libraryElement.units) {
         var source = compilationUnitElement.source;
         LineInfo lineInfo = context.computeLineInfo(source);
-        program.uriToLineStarts["file://${source.fullName}"] =
-            new List<int>.generate(lineInfo.lineCount, lineInfo.getOffsetOfLine,
-                growable: false);
+        String sourceCode = "";
+        try {
+          sourceCode = source.contents.data;

[Kevin Millikin (Google), 2016/12/20 12:03:33]

I think context.getContents(source) will use the analysis context's source cache
instead of reading the file from disk again.  We should probably call that
instead.

[jensj, 2016/12/20 13:30:22]

Done.

+        } catch (e) {
+          // if we cannot read the source code there's nothing to do about that.

[Kevin Millikin (Google), 2016/12/20 12:03:33]

The comment should be a complete sentence (start with a capital letter).  I
prefer to make comments less conversational.

It isn't "we" that's reading the source code, it's the program.  There is
something to do about failing to read the source code, just use ''.  I also
wouldn't presume that the analyzer tried to "read" something, that seems
distracting and misleading to mention here (there are a bunch of different kinds
of Sources and the documentation just says it couldn't be accessed).

I tend to write this like:

String sourceCode;
try {
  sourceCode = context.getContents(source);
} catch (e) {
  // The source's contents could not be accessed.
  sourceCode = '';
}

[jensj, 2016/12/20 13:30:22]

Done.

+        }
+        program.uriToLineStartsAndSource["file://${source.fullName}"] =

[Kevin Millikin (Google), 2016/12/20 12:03:33]

We should probably use source.uri instead of source.fullName.

[jensj, 2016/12/20 13:30:22]

Done.

+            new ast.LineStartsAndSource(
+                new List<int>.from(lineInfo.lineStarts, growable: false),

[Kevin Millikin (Google), 2016/12/20 12:03:33]

lineInfo.lineStarts is already a List<int>, isn't it?

[jensj, 2016/12/20 13:30:22]

Yes.

+                sourceCode);
       }
     }
     return program;
   }
 
   ast.Library loadLibrary(Uri uri) {
     ast.Library library =
         repository.getLibraryReference(applicationRoot.relativeUri(uri));
     ensureLibraryIsLoaded(library);
     return library;
@@ skipping 146 matching lines @@
   AnalysisContext context = AnalysisEngine.instance.createAnalysisContext()
     ..sourceFactory = new SourceFactory(resolvers)
     ..analysisOptions = createAnalysisOptions(options.strongMode);
 
   options.declaredVariables.forEach((String name, String value) {
     context.declaredVariables.define(name, value);
   });
 
   return context;
 }