Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 258763002: Fix promises-aplus testcfg.py (Closed)

Created:
6 years, 8 months ago by yhirano
Modified:
6 years, 7 months ago
CC:
v8-dev, Jakob Kummerow
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Fix promises-aplus testcfg.py Fix GetSourceForTest which returned an incorrect result. With this fix promises-aplus shows correct sources when --cat option is specified. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21026

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M test/promises-aplus/testcfg.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
yhirano
6 years, 8 months ago (2014-04-25 06:30:55 UTC) #1
Jakob Kummerow
lgtm
6 years, 8 months ago (2014-04-25 08:00:42 UTC) #2
rossberg
6 years, 7 months ago (2014-04-28 15:20:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21026 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698