Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2587603003: [sql] Patch SQLite to allow control of close-time WAL checkpoint. (Closed)

Created:
4 years ago by Scott Hess - ex-Googler
Modified:
3 years, 8 months ago
Reviewers:
michaeln
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Patch SQLite to allow control of close-time WAL checkpoint. SQLite WAL mode by default checkpoints the WAL to the main database at close time. Chromium closes databases at shutdown, which causes shutdown slowdowns due to buffered data being flushed. WAL checkpointing would effectively increase the amount of buffered data being flushed. [WAL mode is currently not in use by Chromium.] BUG=675264

Patch Set 1 #

Patch Set 2 : fix UsesUsleep comment from trybot results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -30 lines) Patch
M sql/connection.h View 1 chunk +1 line, -0 lines 0 comments Download
M sql/sqlite_features_unittest.cc View 1 6 chunks +56 lines, -20 lines 0 comments Download
M third_party/sqlite/amalgamation/sqlite3.h View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/sqlite/amalgamation/sqlite3.c View 8 chunks +22 lines, -5 lines 0 comments Download
A third_party/sqlite/patches/0015-backport-Config-database-to-not-checkpoint-WAL-on-cl.patch View 1 chunk +137 lines, -0 lines 0 comments Download
M third_party/sqlite/src/src/btree.c View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/sqlite/src/src/main.c View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/sqlite/src/src/pager.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/sqlite/src/src/pager.c View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/sqlite/src/src/sqlite.h.in View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/sqlite/src/src/sqliteInt.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (6 generated)
Scott Hess - ex-Googler
fix UsesUsleep comment from trybot results
4 years ago (2016-12-17 02:18:47 UTC) #5
Scott Hess - ex-Googler
4 years ago (2016-12-17 02:19:53 UTC) #7
I'm going to start posting some infrastructure changes to get WAL mode working
in tests.  I asked about checkpointing on close on the sqlite-users mailing
list, and was pointed at a patch to the pending release of SQLite, so seems
legit.

Powered by Google App Engine
This is Rietveld 408576698