sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart - Issue 258753004: Use UnmodifiableMapView in compiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart

Issue 258753004: Use UnmodifiableMapView in compiler (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: a few more nits Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart ('k') | sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart

diff --git a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart

index 1ac23d02bd381b096acae89abe9e9d3f461d1a47..46ac3e53b6a9531f074885b2a68f37b12cf61873 100644

--- a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart

+++ b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart

@@ -375,7 +375,7 @@ class Dart2JsFunctionTypeMirror extends Dart2JsTypeMirror

var name = method.qualifiedName;

assert(!map.containsKey(name));

map[name] = method;

- return new ImmutableMapWrapper<Symbol, DeclarationMirror>(map);

+ return new UnmodifiableMapView<Symbol, DeclarationMirror>(map);

}

return originalDeclaration.declarations;

}