sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart - Issue 258753004: Use UnmodifiableMapView in compiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart

Issue 258753004: Use UnmodifiableMapView in compiler (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/docgen/lib/src/models/class.dart ('K') | « sdk/lib/_internal/compiler/implementation/dart2jslib.dart ('k') | sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart » ('j') | sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart

diff --git a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart

index a4f88c2f31249cf227cd1a0d8a895d12189de20e..2cfb0cec8eb638c0ae72ff9b6da3ed3cccedde15 100644

--- a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart

+++ b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart

@@ -4,7 +4,7 @@

library dart2js.mirrors;

-import 'dart:collection' show UnmodifiableListView;

+import 'dart:collection' show UnmodifiableListView, UnmodifiableMapView;

import '../elements/elements.dart';

import '../scanner/scannerlib.dart';

@@ -385,7 +385,7 @@ abstract class ContainerMixin {

Map<Symbol, DeclarationMirror> get declarations {

_ensureDeclarations();

- return new ImmutableMapWrapper<Symbol, DeclarationMirror>(_declarations);

+ return new UnmodifiableMapView<Symbol, DeclarationMirror>(_declarations);

}