Use UnmodifiableMapView in compiler

pkg/docgen/lib/src/models/class.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library docgen.models.clazz;
 
+import 'dart:collection';
+
 import '../exports/dart2js_mirrors.dart' as dart2js_mirrors;
 import '../exports/mirrors_util.dart' as dart2js_util;
 import '../exports/source_mirrors.dart';
 
 import '../library_helpers.dart';
 
 import 'dummy_mirror.dart';
 import 'generic.dart';
 import 'library.dart';
 import 'method.dart';
@@ skipping 62 matching lines @@
     // The reason we do this madness is the superclass and interface owners may
     // not be this class's owner!! Example: BaseClient in http pkg.
     var superinterfaces = classMirror.superinterfaces.map(
         (interface) => new Class._possiblyDifferentOwner(interface, owner));
     this._superclass = classMirror.superclass == null? null :
         new Class._possiblyDifferentOwner(classMirror.superclass, owner);
 
     interfaces = superinterfaces.toList();
     variables = createVariables(
         dart2js_util.variablesOf(classMirror.declarations), this);
-    methods = createMethods(classMirror.declarations.values.where(
-        (mirror) => mirror is MethodMirror), this);
+    methods = createMethods(new TypeOfIterable<MethodMirror>(

[herhut, 2014/04/28 08:24:41]

Maybe rather expose [anyMethodOf] and use that. Would remove the code
duplication from below and hide more of the inner workings in the mirror code
base.

[kevmoo, 2014/04/28 09:23:01]

Done.

+        classMirror.declarations.values), this);
 
     // Tell superclass that you are a subclass, unless you are not
     // visible or an intermediary mixin class.
     if (!classMirror.isNameSynthetic && isVisible && _superclass != null) {
       _superclass.addSubclass(this);
     }
 
     if (this._superclass != null) addInherited(_superclass);
     interfaces.forEach((interface) => addInherited(interface));
   }
@@ skipping 135 matching lines @@
     'methods': expandMethodMap(methods),
     'inheritedMethods': expandMethodMap(inheritedMethods),
     'annotations': annotations.map((a) => a.toMap()).toList(),
     'generics': recurseMap(generics)
   };
 
   int compareTo(Class other) => name.compareTo(other.name);
 
   bool isValidMirror(DeclarationMirror mirror) => mirror is ClassMirror;
 }
+
+class TypeOfIterable<TTarget> extends IterableBase<TTarget> {

[herhut, 2014/04/28 08:24:41]

Nit: I prefer using just T for the type variable because it reads easier.

+  final Iterable _source;
+
+  TypeOfIterable(this._source);
+
+  Iterator<TTarget> get iterator =>
+      new _TypeOfIterator<TTarget>(_source.iterator);
+}
+
+class _TypeOfIterator<TTarget> implements Iterator<TTarget> {
+  final Iterator _source;
+
+  TTarget get current => _source.current as TTarget;

[herhut, 2014/04/28 08:24:41]

Do you really need the runtime check via as here? By construction this should be
safe and in checked mode the return type will be checked.

+
+  _TypeOfIterator(this._source);
+
+  bool moveNext() {
+    while(_source.moveNext()) {
+      if (_source.current is TTarget) {
+        return true;
+      }
+    }
+    return false;
+  }
+}