Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js

Issue 2587463002: [Fetch API] Appending headers of the same name should have their values (Closed)
Patch Set: flag to found Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js b/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js
index d9af65cfb6029d13d5fe5df46edb80697838f33f..7c36bb3e9ff5ba02715f76b1eda79d96a81abbaa 100644
--- a/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js
+++ b/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js
@@ -136,7 +136,7 @@ test(function() {
headers.append('X-FETCH-TEST-2', 'response test field - append');
assert_equals(size(headers), 5, 'headers size should increase by 1.');
assert_equals(headers.get('X-FETCH-Test'),
- 'response test field - updated',
+ 'response test field - updated,response test field - append',
'the value of the first header added should be returned.');
allValues = headers.getAll('X-FETch-TEST');
assert_equals(allValues.length, 2);
@@ -156,7 +156,7 @@ test(function() {
headers = new Headers([['a', 'b'], ['c', 'd'], ['c', 'e']]);
assert_equals(size(headers), 2, 'headers size should match');
assert_equals(headers.get('a'), 'b');
- assert_equals(headers.get('c'), 'd');
+ assert_equals(headers.get('c'), 'd,e');
assert_equals(headers.getAll('c')[0], 'd');
assert_equals(headers.getAll('c')[1], 'e');
@@ -164,13 +164,25 @@ test(function() {
var headers2 = new Headers(headers);
assert_equals(size(headers2), 2, 'headers size should match');
assert_equals(headers2.get('a'), 'b');
- assert_equals(headers2.get('c'), 'd');
+ assert_equals(headers2.get('c'), 'd,e');
assert_equals(headers2.getAll('c')[0], 'd');
assert_equals(headers2.getAll('c')[1], 'e');
headers.set('a', 'x');
assert_equals(headers.get('a'), 'x');
assert_equals(headers2.get('a'), 'b');
+ var headers3 = new Headers();
+ headers3.append('test', 'a');
+ headers3.append('test', '');
+ headers3.append('test', 'b');
+ assert_equals(headers3.get('test'), 'a,,b');
+ headers3.set('test', '');
+ assert_equals(headers3.get('test'), '');
+
+ var headers4 = new Headers();
+ headers4.append('foo', '');
+ headers4.append('foo', 'a');
+ assert_equals(headers4.get('foo'), ',a');
// new Headers with Dictionary
headers = new Headers({'a': 'b', 'c': 'd'});
assert_equals(size(headers), 2, 'headers size should match');

Powered by Google App Engine
This is Rietveld 408576698