[Fetch API] Appending headers of the same name should have their values

third_party/WebKit/Source/modules/fetch/Headers.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/fetch/Headers.h"
 
 #include "bindings/core/v8/Dictionary.h"
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/V8IteratorResultValue.h"
 #include "core/dom/Iterator.h"
@@ skipping 159 matching lines @@
   m_headerList->remove(name);
 }
 
 String Headers::get(const String& name, ExceptionState& exceptionState) {
   // "The get(|name|) method, when invoked, must run these steps:"
   // "1. If |name| is not a name, throw a TypeError."
   if (!FetchHeaderList::isValidHeaderName(name)) {
     exceptionState.throwTypeError("Invalid name");
     return String();
   }
-  // "2. Return the value of the first header in header list whose name is
-  //     |name|, and null otherwise."
+  // "2. If there is no header in header list whose name is name, return null."

[yhirano, 2016/12/19 11:43:05]

whose name is |name|

+  // "3. Return |result| as the combined header list."

[yhirano, 2016/12/19 11:43:05]

Where does this statement come from? Isn't it

"3. Return the combined value given |name| and header list."?

   String result;
   m_headerList->get(name, result);
   return result;
 }
 
 Vector<String> Headers::getAll(const String& name,
                                ExceptionState& exceptionState) {
   // "The getAll(|name|) method, when invoked, must run these steps:"
   // "1. If |name| is not a name, throw a TypeError."
   if (!FetchHeaderList::isValidHeaderName(name)) {
@@ skipping 128 matching lines @@
   visitor->trace(m_headerList);
 }
 
 PairIterable<String, String>::IterationSource* Headers::startIteration(
     ScriptState*,
     ExceptionState&) {
   return new HeadersIterationSource(m_headerList);
 }
 
 }  // namespace blink