predictors: Make speculative_prefetch_predictor work with PlzNavigate

chrome/browser/predictors/resource_prefetch_common.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/predictors/resource_prefetch_common.h"
 
 #include <string>
 #include <tuple>
 
 #include "base/command_line.h"
@@ skipping 58 matching lines @@
           ResourcePrefetchPredictorConfig::LEARNING |
           ResourcePrefetchPredictorConfig::PREFETCHING_FOR_NAVIGATION |
           ResourcePrefetchPredictorConfig::PREFETCHING_FOR_EXTERNAL;
       return true;
     }
   }
 
   return false;
 }
 
-NavigationID::NavigationID()
-    : render_process_id(-1),
-      render_frame_id(-1) {
+NavigationID::NavigationID() {
+  session_id.set_id(-1);  // Invalid.
 }
 
 NavigationID::NavigationID(const NavigationID& other)
-    : render_process_id(other.render_process_id),
-      render_frame_id(other.render_frame_id),
+    : session_id(other.session_id),
       main_frame_url(other.main_frame_url),
-      creation_time(other.creation_time) {
-}
+      creation_time(other.creation_time) {}
 
 NavigationID::NavigationID(content::WebContents* web_contents)
-    : render_process_id(web_contents->GetRenderProcessHost()->GetID()),
-      render_frame_id(web_contents->GetMainFrame()->GetRoutingID()),
-      main_frame_url(web_contents->GetURL()) {
+    : main_frame_url(web_contents->GetURL()),
+      creation_time(base::TimeTicks::Now()) {
+  session_id.set_id(SessionTabHelper::IdForTab(web_contents));

[Benoit L, 2016/12/19 16:55:55]

While the intent is clear here, it is still a bit strange to wrap the return
value of this function instead of storing it directly. See the comment above.

 }
 
 NavigationID::NavigationID(content::WebContents* web_contents,
                            const GURL& main_frame_url,
                            const base::TimeTicks& creation_time)
-    : render_process_id(web_contents->GetRenderProcessHost()->GetID()),
-      render_frame_id(web_contents->GetMainFrame()->GetRoutingID()),
-      main_frame_url(main_frame_url),
-      creation_time(creation_time) {}
+    : main_frame_url(main_frame_url), creation_time(creation_time) {
+  session_id.set_id(SessionTabHelper::IdForTab(web_contents));
+}
 
 bool NavigationID::is_valid() const {
-  return render_process_id != -1 && render_frame_id != -1 &&
-      !main_frame_url.is_empty();
+  return session_id.id() != -1 && !main_frame_url.is_empty();
 }
 
 bool NavigationID::operator<(const NavigationID& rhs) const {
   DCHECK(is_valid() && rhs.is_valid());
-  return std::tie(render_process_id, render_frame_id, main_frame_url) <
-    std::tie(rhs.render_process_id, rhs.render_frame_id, rhs.main_frame_url);
+  // Quick int copy to be able to use tie.
+  int id_lhs = session_id.id();
+  int id_rhs = rhs.session_id.id();
+  return std::tie(id_lhs, main_frame_url) <
+         std::tie(id_rhs, rhs.main_frame_url);
 }
 
 bool NavigationID::operator==(const NavigationID& rhs) const {
   DCHECK(is_valid() && rhs.is_valid());
-  return IsSameRenderer(rhs) && main_frame_url == rhs.main_frame_url;
-}
-
-bool NavigationID::IsSameRenderer(const NavigationID& other) const {
-  DCHECK(is_valid() && other.is_valid());
-  return render_process_id == other.render_process_id &&
-      render_frame_id == other.render_frame_id;
+  return session_id.id() == rhs.session_id.id() &&
+         main_frame_url == rhs.main_frame_url;
 }
 
 ResourcePrefetchPredictorConfig::ResourcePrefetchPredictorConfig()
     : mode(0),
       max_navigation_lifetime_seconds(60),
       max_urls_to_track(500),
       max_hosts_to_track(200),
       min_url_visit_count(2),
       max_resources_per_entry(50),
       max_consecutive_misses(3),
@@ skipping 48 matching lines @@
 
 bool ResourcePrefetchPredictorConfig::IsMoreResourcesEnabledForTest() const {
   return max_resources_per_entry == 100;
 }
 
 bool ResourcePrefetchPredictorConfig::IsSmallDBEnabledForTest() const {
   return max_urls_to_track == 200 && max_hosts_to_track == 100;
 }
 
 }  // namespace predictors