Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1748)

Unified Diff: base/path_service.h

Issue 258743005: Enable Enterprise enrollment on desktop builds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: added arg to PathService::OverrideAndCreateIfNeeded, added test for FakeCryptohomeClient::InstallAt… Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/path_service.cc » ('j') | chromeos/dbus/fake_cryptohome_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/path_service.h
diff --git a/base/path_service.h b/base/path_service.h
index 9759754377f9a060b04e6503e12884d395b7217a..554eb9e346443b4baa48b270907920722f9ff364 100644
--- a/base/path_service.h
+++ b/base/path_service.h
@@ -46,11 +46,18 @@ class BASE_EXPORT PathService {
// one test should not carry over to another.
static bool Override(int key, const base::FilePath& path);
- // This function does the same as PathService::Override but it takes an extra
- // parameter |create| which guides whether the directory to be overriden must
+ // This function does the same as PathService::Override but it takes extra
+ // parameters:
+ // - |is_absolute| indicates that |path| has already been expanded into an
+ // absolute path, otherwise MakeAbsoluteFilePath() will be used. This is
+ // useful to override paths that may not exist yet, since MakeAbsoluteFilePath
+ // fails for those. Note that MakeAbsoluteFilePath also expands symbolic
+ // links, even if path.IsAbsolute() is already true.
+ // - |create| guides whether the directory to be overriden must
// be created in case it doesn't exist already.
static bool OverrideAndCreateIfNeeded(int key,
const base::FilePath& path,
+ bool is_absolute,
bool create);
// To extend the set of supported keys, you can register a path provider,
« no previous file with comments | « no previous file | base/path_service.cc » ('j') | chromeos/dbus/fake_cryptohome_client.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698