third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl - Issue 2587383002: Add [PrefixGet] extended attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl

Issue 2587383002: Add [PrefixGet] extended attribute (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl ('k') | third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl

index e1480637e527dee214e8662d1c8de61036d0f662..78cc47bd12e7eae372b681a7a6112bff380572f4 100644

--- a/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl

@@ -105,7 +105,7 @@ bool toV8{{cpp_class}}(const {{cpp_class}}& impl, v8::Local<v8::Object> dictiona

{% for member in members %}

if (impl.{{member.has_method_name}}()) {

{% if member.is_object %}

- DCHECK(impl.{{member.cpp_name}}().isObject());

+ DCHECK(impl.{{member.getter_name}}().isObject());

{% endif %}

if (!v8CallBoolean(dictionary->CreateDataProperty(isolate->GetCurrentContext(), v8String(isolate, "{{member.name}}"), {{member.cpp_value_to_v8_value}})))

return false;