Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1652)

Unified Diff: test/unittests/heap/embedder-tracing-unittest.cc

Issue 2587363002: [heap] Fix unittest compilation on mips (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/heap/embedder-tracing-unittest.cc
diff --git a/test/unittests/heap/embedder-tracing-unittest.cc b/test/unittests/heap/embedder-tracing-unittest.cc
index 0b321ef4cc0e6e7dc4ec98467ff6b820a0e24467..5e53177238284afef6332ef8962d18cc52d3caea 100644
--- a/test/unittests/heap/embedder-tracing-unittest.cc
+++ b/test/unittests/heap/embedder-tracing-unittest.cc
@@ -136,11 +136,9 @@ TEST(LocalEmbedderHeapTracer, TraceFinishes) {
EXPECT_EQ(1u, local_tracer.NumberOfCachedWrappersToTrace());
EXPECT_CALL(remote_tracer, RegisterV8References(_));
EXPECT_CALL(remote_tracer, AdvanceTracing(0, _)).WillOnce(Return(false));
- EXPECT_EQ(
- false,
- local_tracer.Trace(
- 0, EmbedderHeapTracer::AdvanceTracingActions(
- EmbedderHeapTracer::ForceCompletionAction::FORCE_COMPLETION)));
+ EXPECT_FALSE(local_tracer.Trace(
+ 0, EmbedderHeapTracer::AdvanceTracingActions(
+ EmbedderHeapTracer::ForceCompletionAction::FORCE_COMPLETION)));
EXPECT_EQ(0u, local_tracer.NumberOfCachedWrappersToTrace());
}
@@ -152,11 +150,9 @@ TEST(LocalEmbedderHeapTracer, TraceDoesNotFinish) {
EXPECT_EQ(1u, local_tracer.NumberOfCachedWrappersToTrace());
EXPECT_CALL(remote_tracer, RegisterV8References(_));
EXPECT_CALL(remote_tracer, AdvanceTracing(0, _)).WillOnce(Return(true));
- EXPECT_EQ(
- true,
- local_tracer.Trace(
- 0, EmbedderHeapTracer::AdvanceTracingActions(
- EmbedderHeapTracer::ForceCompletionAction::FORCE_COMPLETION)));
+ EXPECT_TRUE(local_tracer.Trace(
+ 0, EmbedderHeapTracer::AdvanceTracingActions(
+ EmbedderHeapTracer::ForceCompletionAction::FORCE_COMPLETION)));
EXPECT_EQ(0u, local_tracer.NumberOfCachedWrappersToTrace());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698