Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2587343006: Runtime support for Null as any in dart2js (Closed)

Created:
4 years ago by Johnni Winther
Modified:
4 years ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, regis
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Patch Set 3 : Update tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -0 lines) Patch
M sdk/lib/_internal/js_runtime/lib/js_helper.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_rti.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language.status View 1 2 2 chunks +15 lines, -0 lines 0 comments Download
A tests/language/null_is_bottom_test.dart View 1 2 1 chunk +142 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years ago (2016-12-21 12:33:46 UTC) #2
floitsch
LGTM! https://codereview.chromium.org/2587343006/diff/1/tests/language/null_is_bottom_test.dart File tests/language/null_is_bottom_test.dart (right): https://codereview.chromium.org/2587343006/diff/1/tests/language/null_is_bottom_test.dart#newcode93 tests/language/null_is_bottom_test.dart:93: testIsReturnA(returnA); /// 19: ok Needs to be in ...
4 years ago (2016-12-21 12:45:05 UTC) #3
Johnni Winther
https://codereview.chromium.org/2587343006/diff/1/tests/language/null_is_bottom_test.dart File tests/language/null_is_bottom_test.dart (right): https://codereview.chromium.org/2587343006/diff/1/tests/language/null_is_bottom_test.dart#newcode93 tests/language/null_is_bottom_test.dart:93: testIsReturnA(returnA); /// 19: ok On 2016/12/21 12:45:05, floitsch wrote: ...
4 years ago (2016-12-21 13:17:54 UTC) #4
Johnni Winther
4 years ago (2016-12-21 13:59:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
0a1ed5fab488ad955ff2d6499e2ce981a3fbf854 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698