Simplify old space allocation strategy.

Simplify old space allocation strategy.

BUG=
R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21017

[Michael Starzinger, 2014-04-28 12:22:01]

LGTM. I like it. Let's hope that the overall system is sane enough already for
that simplification.

https://codereview.chromium.org/258733013/diff/2/src/spaces.cc
File src/spaces.cc (right):

https://codereview.chromium.org/258733013/diff/2/src/spaces.cc#newcode2592
src/spaces.cc:2592: MarkCompactCollector* collector =
heap()->mark_compact_collector();
nit: Let's move this down two lines to after the next comment. Otherwise it
looks like the "Allocation in this space has failed" applies to the getter.

https://codereview.chromium.org/258733013/diff/2/src/spaces.cc#newcode2621
src/spaces.cc:2621: // After waiting for the sweeper threads, there may be new
free-list
nit: s/may be/are/

[Hannes Payer (out of office), 2014-04-28 12:51:06]

https://codereview.chromium.org/258733013/diff/2/src/spaces.cc
File src/spaces.cc (right):

https://codereview.chromium.org/258733013/diff/2/src/spaces.cc#newcode2592
src/spaces.cc:2592: MarkCompactCollector* collector =
heap()->mark_compact_collector();
On 2014/04/28 12:22:01, Michael Starzinger wrote:
> nit: Let's move this down two lines to after the next comment. Otherwise it
> looks like the "Allocation in this space has failed" applies to the getter.

Done.

https://codereview.chromium.org/258733013/diff/2/src/spaces.cc#newcode2621
src/spaces.cc:2621: // After waiting for the sweeper threads, there may be new
free-list
On 2014/04/28 12:22:01, Michael Starzinger wrote:
> nit: s/may be/are/

I think "may be" is correct. It may be the case that the sweeper threads sweep a
page and are not able to find free memory chunks.

[Hannes Payer (out of office), 2014-04-28 12:58:41]

Committed patchset #3 manually as r21017 (presubmit successful).