Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 258733003: Mojo: Mojom: Add flag to force using bundled Python modules. (Closed)

Created:
6 years, 8 months ago by viettrungluu
Modified:
6 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Mojom: Add flag to force using bundled Python modules. (And make it the default in mojom_bindings_generator.gypi, so people who have other/older system-installed versions of ply or jinja2 don't get broken.) TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M mojo/public/tools/bindings/mojom_bindings_generator.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/tools/bindings/mojom_bindings_generator.py View 5 chunks +22 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
6 years, 8 months ago (2014-04-25 05:00:51 UTC) #1
Nico
Why is this better than https://codereview.chromium.org/250953003/ ? It's more complex. Under which circumstances would you ...
6 years, 8 months ago (2014-04-25 17:20:48 UTC) #2
viettrungluu
On 2014/04/25 17:20:48, Nico wrote: > Why is this better than https://codereview.chromium.org/250953003/ ? It's more ...
6 years, 8 months ago (2014-04-25 17:21:10 UTC) #3
Nico
Trung explained this to me: "(For context: things under mojo/public are meant to be usable ...
6 years, 8 months ago (2014-04-25 17:27:42 UTC) #4
viettrungluu
6 years, 8 months ago (2014-04-25 18:00:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r266212 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698