Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 258733002: Block some HID devices from chrome.hid. (Closed)

Created:
6 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 7 months ago
Reviewers:
rpaquay
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Block some HID devices from chrome.hid. This blacklists some specific types of HID devices from being accessible to the chrome.hid API. Namely, any keyboard, mice, other pointer devices, or system control inputs (such as power and reset buttons) are blocked and cannot be enumerated or opened by the consumers of the API. BUG=355022 R=rpaquay Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266482

Patch Set 1 #

Patch Set 2 : test TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -1 line) Patch
M chrome/browser/extensions/api/hid/hid_device_manager.h View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/hid/hid_device_manager.cc View 1 3 chunks +47 lines, -1 line 0 comments Download
M device/hid/hid_usage_and_page.h View 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Ken Rockot(use gerrit already)
Renaud, could you please take a look at this?
6 years, 8 months ago (2014-04-25 02:31:38 UTC) #1
rpaquay
lgtm. Would adding test(s) be useful?
6 years, 8 months ago (2014-04-25 18:59:19 UTC) #2
Ken Rockot(use gerrit already)
On 2014/04/25 18:59:19, rpaquay wrote: > lgtm. Would adding test(s) be useful? Yeah, that would ...
6 years, 8 months ago (2014-04-25 19:24:11 UTC) #3
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-25 19:24:17 UTC) #4
Ken Rockot(use gerrit already)
The CQ bit was unchecked by rockot@chromium.org
6 years, 8 months ago (2014-04-25 19:24:22 UTC) #5
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-25 19:24:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/258733002/20001
6 years, 8 months ago (2014-04-25 22:10:18 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 00:17:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-26 00:17:21 UTC) #9
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-26 20:46:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/258733002/20001
6 years, 8 months ago (2014-04-26 20:48:05 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 21:38:11 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-26 21:38:11 UTC) #13
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-27 02:21:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/258733002/20001
6 years, 8 months ago (2014-04-27 02:21:55 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 08:05:13 UTC) #16
Message was sent while issue was closed.
Change committed as 266482

Powered by Google App Engine
This is Rietveld 408576698